Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 23, 2024

Backport of #6413 to release/9.0

/cc @joperezr @radical

Customer Impact

Testing

Risk

Regression?

Microsoft Reviewers: Open in CodeFlow

@joperezr
Copy link
Member

This is needed in order to be able to build internally with stable versions of the rest of .NET, as those require special infrastructure.

@joperezr
Copy link
Member

Merging as tell mode as we need this to get a coherent build out.

@joperezr joperezr merged commit 8f0bda6 into release/9.0 Oct 24, 2024
8 checks passed
@joperezr joperezr deleted the backport/pr-6413-to-release/9.0 branch October 24, 2024 00:25
joperezr added a commit to joperezr/aspire that referenced this pull request Nov 13, 2024
#### AI description  (iteration 1)
#### PR Classification
Merge branch `release/9.0` into `internal/release/9.0` to integrate recent changes and address specific work items.

#### PR Summary
This pull request integrates changes from the `release/9.0` branch into `internal/release/9.0`, addressing several work items related to Azure storage and network isolation.
- `/tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs`: Added a new test `ConfigureCustomDomainsMutatesIngress` to validate custom domain configuration for Azure Container Apps.
- `/src/Aspire.Hosting.Azure.AppContainers/ContainerAppExtensions.cs`: Introduced a new extension method `ConfigureCustomDomain` to simplify the process of assigning custom domains to Azure Container Apps.

Related work items: dotnet#6368, dotnet#6391, dotnet#6433, dotnet#6458, dotnet#6467
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants