Skip to content

[tests] Quarantine, and un-quarantine some tests #8545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025
Merged

[tests] Quarantine, and un-quarantine some tests #8545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb5ff3b
[tests] Re-enable Aspire.Hosting.Testing.Tests.TestingFactoryTests.Ht…
radical Apr 4, 2025
8d5b9d2
Quarantine Aspire.Dashboard.Components.Tests.Pages.TraceDetailsTests.…
radical Apr 4, 2025
71f176d
fix build
radical Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/Aspire.Dashboard.Components.Tests/Pages/TraceDetailsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using Aspire.Dashboard.Model.Otlp;
using Aspire.Dashboard.Otlp.Model;
using Aspire.Dashboard.Otlp.Storage;
using Aspire.TestUtilities;
using Bunit;
using Google.Protobuf.Collections;
using Microsoft.AspNetCore.InternalTesting;
Expand Down Expand Up @@ -82,6 +83,7 @@ public void Render_HasTrace_SubscriptionRemovedOnDispose()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8546")]
public async Task Render_ChangeTrace_RowsRendered()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion tests/Aspire.Hosting.Testing.Tests/TestingFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ public void CanGetResources()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4650")]
public async Task HttpClientGetTest()
{
// Wait for the application to be ready
Expand Down
Loading