Fix visibility updates during resource upserts #9264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
May 12, 2025
| @@ -305,6 +305,53 @@ private static void AssertResourceFilterListEquals(IRenderedComponent<Components | |||
| Assert.Equal(healthStates, healthSelect.Instance.Values.ToImmutableSortedDictionary() /* sort for equality comparison */); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void ResourcesShouldRemainUnchangedWhenFilterDoesNotMatchUpdatedResource() | |||
There was a problem hiding this comment.
does this test all 3 lines of your fix above?
JamesNK
approved these changes
May 13, 2025
|
/backport to release/9.3 |
|
Started backporting to release/9.3: https://github.com/dotnet/aspire/actions/runs/14986296044 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when upserting a resource, the visibility function passed to
UpdateFromResourcewould return false in the event that any value in the dictionary was false. For example, ifcontainerandprojectare values,containeris marked as hidden (false), and then a resource of typeprojectis updated,projectwill then be set to hidden. This is incorrect. Instead, the value should be visible if it was previously visible in the dictionary or if it's new (ie, when stopping a command, you may see the stateStoppingfor the first time).Fixes #9220
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate