Skip to content

Commit 225506b

Browse files
committed
Fix test
1 parent e034973 commit 225506b

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

src/Servers/Kestrel/Core/src/ListenOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ internal virtual string GetDisplayName()
153153
case UnixDomainSocketEndPoint _:
154154
return $"{Scheme}://unix:{EndPoint}";
155155
case NamedPipeEndPoint namedPipeEndPoint:
156-
return $"{Scheme}://pipe:{namedPipeEndPoint.PipeName}";
156+
return $"{Scheme}://pipe:/{namedPipeEndPoint.PipeName}";
157157
case FileHandleEndPoint _:
158158
return $"{Scheme}://<file handle>";
159159
default:

src/Servers/Kestrel/Core/test/AddressBinderTests.cs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,28 +90,34 @@ public void ParseAddress_HasPipeNoSlash()
9090
[Fact]
9191
public void ParseAddressNamedPipe()
9292
{
93-
var listenOptions = AddressBinder.ParseAddress("http://pipe:/HelloWorld", out var https);
93+
var address = "http://pipe:/HelloWorld";
94+
var listenOptions = AddressBinder.ParseAddress(address, out var https);
9495
Assert.IsType<NamedPipeEndPoint>(listenOptions.EndPoint);
9596
Assert.Equal("HelloWorld", listenOptions.PipeName);
9697
Assert.False(https);
98+
Assert.Equal(address, listenOptions.GetDisplayName());
9799
}
98100

99101
[Fact]
100102
public void ParseAddressNamedPipe_BackSlashes()
101103
{
102-
var listenOptions = AddressBinder.ParseAddress(@"http://pipe:/LOCAL\HelloWorld", out var https);
104+
var address = @"http://pipe:/LOCAL\HelloWorld";
105+
var listenOptions = AddressBinder.ParseAddress(address, out var https);
103106
Assert.IsType<NamedPipeEndPoint>(listenOptions.EndPoint);
104107
Assert.Equal(@"LOCAL\HelloWorld", listenOptions.PipeName);
105108
Assert.False(https);
109+
Assert.Equal(address, listenOptions.GetDisplayName());
106110
}
107111

108112
[Fact]
109113
public void ParseAddressNamedPipe_ForwardSlashes()
110114
{
111-
var listenOptions = AddressBinder.ParseAddress("http://pipe://tmp/kestrel-test.sock", out var https);
115+
var address = "http://pipe://tmp/kestrel-test.sock";
116+
var listenOptions = AddressBinder.ParseAddress(address, out var https);
112117
Assert.IsType<NamedPipeEndPoint>(listenOptions.EndPoint);
113118
Assert.Equal("/tmp/kestrel-test.sock", listenOptions.PipeName);
114119
Assert.False(https);
120+
Assert.Equal(address, listenOptions.GetDisplayName());
115121
}
116122

117123
[ConditionalFact]

src/Servers/Kestrel/Transport.NamedPipes/test/WebHostTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ public async Task ListenNamedPipeEndpoint_FromUrl_HelloWorld_ClientSuccess()
287287
// Arrange
288288
using var httpEventSource = new HttpEventSourceListener(LoggerFactory);
289289
var pipeName = NamedPipeTestHelpers.GetUniquePipeName();
290-
var url = $"http://pipe:{pipeName}";
290+
var url = $"http://pipe:/{pipeName}";
291291

292292
var builder = new HostBuilder()
293293
.ConfigureWebHost(webHostBuilder =>

0 commit comments

Comments
 (0)