Comment

JamesNK · JamesNK · commit 6b4e99ca1d41 · 2022-12-10T11:21:15.000+08:00
diff --git a/src/Servers/Kestrel/Core/test/AddressBinderTests.cs b/src/Servers/Kestrel/Core/test/AddressBinderTests.cs
@@ -81,6 +81,8 @@ public void ParseAddressLocalhost()
     [Fact]
     public void ParseAddress_HasPipeNoSlash()
     {
+        // Pipe prefix is missing slash here and so the address is parsed as an IP.
+        // The slash is required to differentiate between a pipe and a hostname.
         var listenOptions = AddressBinder.ParseAddress("http://pipe:8080", out var https);
         Assert.IsType<IPEndPoint>(listenOptions.EndPoint);
         Assert.Equal(8080, listenOptions.IPEndPoint.Port);

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,8 @@ public void ParseAddressLocalhost()`
`81`	`81`	`[Fact]`
`82`	`82`	`public void ParseAddress_HasPipeNoSlash()`
`83`	`83`	`{`
	`84`	`+ // Pipe prefix is missing slash here and so the address is parsed as an IP.`
	`85`	`+ // The slash is required to differentiate between a pipe and a hostname.`
`84`	`86`	`var listenOptions = AddressBinder.ParseAddress("http://pipe:8080", out var https);`
`85`	`87`	`Assert.IsType<IPEndPoint>(listenOptions.EndPoint);`
`86`	`88`	`Assert.Equal(8080, listenOptions.IPEndPoint.Port);`