Skip to content

Commit acf1dc4

Browse files
John Luopranavkm
John Luo
andauthored
Api docs for ResponseCaching (#26531)
* Api docs for ResponseCaching * Enable warnings for HostFiltering, HttpsPolicy and StaticFiles * Update src/Middleware/ResponseCaching/src/ResponseCachingFeature.cs Co-authored-by: Pranav K <[email protected]> * Add more details Co-authored-by: Pranav K <[email protected]>
1 parent 659532b commit acf1dc4

7 files changed

+14
-4
lines changed

src/Middleware/HostFiltering/src/Microsoft.AspNetCore.HostFiltering.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
</Description>
77
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
88
<IsAspNetCoreApp>true</IsAspNetCoreApp>
9+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
910
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1011
<PackageTags>aspnetcore</PackageTags>
1112
<IsPackable>false</IsPackable>

src/Middleware/HttpsPolicy/src/Microsoft.AspNetCore.HttpsPolicy.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</Description>
77
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
88
<IsAspNetCoreApp>true</IsAspNetCoreApp>
9-
<NoWarn>$(NoWarn);CS1591</NoWarn>
9+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
1010
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1111
<PackageTags>aspnetcore;https;hsts</PackageTags>
1212
<IsPackable>false</IsPackable>

src/Middleware/ResponseCaching.Abstractions/src/Microsoft.AspNetCore.ResponseCaching.Abstractions.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
66
<IsAspNetCoreApp>true</IsAspNetCoreApp>
77
<GenerateDocumentationFile>true</GenerateDocumentationFile>
8+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
89
<PackageTags>aspnetcore;cache;caching</PackageTags>
910
<IsPackable>false</IsPackable>
1011
</PropertyGroup>

src/Middleware/ResponseCaching/src/Microsoft.AspNetCore.ResponseCaching.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<Description>ASP.NET Core middleware for caching HTTP responses on the server.</Description>
55
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
66
<IsAspNetCoreApp>true</IsAspNetCoreApp>
7-
<NoWarn>$(NoWarn);CS1591</NoWarn>
7+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
88
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
99
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1010
<PackageTags>aspnetcore;cache;caching</PackageTags>

src/Middleware/ResponseCaching/src/ResponseCachingFeature.cs

+2
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55

66
namespace Microsoft.AspNetCore.ResponseCaching
77
{
8+
/// Default implementation for <see cref="IResponseCachingFeature" />
89
public class ResponseCachingFeature : IResponseCachingFeature
910
{
1011
private string[] _varyByQueryKeys;
1112

13+
/// <inheritdoc />
1214
public string[] VaryByQueryKeys
1315
{
1416
get

src/Middleware/ResponseCaching/src/ResponseCachingOptions.cs

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,25 @@
1-
// Copyright (c) .NET Foundation. All rights reserved.
1+
// Copyright (c) .NET Foundation. All rights reserved.
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

44
using System.ComponentModel;
55

66
namespace Microsoft.AspNetCore.ResponseCaching
77
{
8+
/// <summary>
9+
/// Options for configuring the <see cref="ResponseCachingMiddleware"/>.
10+
/// </summary>
811
public class ResponseCachingOptions
912
{
1013
/// <summary>
1114
/// The size limit for the response cache middleware in bytes. The default is set to 100 MB.
15+
/// When this limit is exceeded, no new responses will be cached until older entries are
16+
/// evicted.
1217
/// </summary>
1318
public long SizeLimit { get; set; } = 100 * 1024 * 1024;
1419

1520
/// <summary>
1621
/// The largest cacheable size for the response body in bytes. The default is set to 64 MB.
22+
/// If the response body exceeds this limit, it will not be cached by the <see cref="ResponseCachingMiddleware"/>.
1723
/// </summary>
1824
public long MaximumBodySize { get; set; } = 64 * 1024 * 1024;
1925

src/Middleware/StaticFiles/src/Microsoft.AspNetCore.StaticFiles.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<Description>ASP.NET Core static files middleware. Includes middleware for serving static files, directory browsing, and default files.</Description>
55
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
66
<IsAspNetCoreApp>true</IsAspNetCoreApp>
7-
<NoWarn>$(NoWarn);CS1591</NoWarn>
7+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
88
<GenerateDocumentationFile>true</GenerateDocumentationFile>
99
<PackageTags>aspnetcore;staticfiles</PackageTags>
1010
<IsPackable>false</IsPackable>

0 commit comments

Comments
 (0)