Api docs for ResponseCaching #26531
Merged
Api docs for ResponseCaching #26531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
added
the
tell-mode
ghost
added
the
pranavkm
reviewed
Oct 2, 2020
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System.ComponentModel; | ||
|
|
||
| namespace Microsoft.AspNetCore.ResponseCaching | ||
| { | ||
| /// <summary> | ||
| /// Options for configuring the <see cref="ResponseCachingMiddleware"/>. | ||
| /// </summary> | ||
| public class ResponseCachingOptions |
There was a problem hiding this comment.
- For the
SizeLimitproperty below, do you think it's valuable to explain what happens once the limit is hit? - For
MaximumBodySizeshould we add what happens if the limit is exceeded?
Tratcher
approved these changes
Oct 2, 2020
Co-authored-by: Pranav K <[email protected]>
|
@pranavkm 🆙📅 |
pranavkm
approved these changes
Oct 2, 2020
|
Hello @JunTaoLuo! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
amcasey
added
the
area-middleware
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26397.
Breaking it up into smaller PRs for review. This one covers ResponseCaching, StaticFiles, HostFilter and HttpsPolicy.