Skip to content

MicrosoftAccount to take parameters #11026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
worthy7 opened this issue Jun 10, 2019 · 7 comments
Closed

MicrosoftAccount to take parameters #11026

worthy7 opened this issue Jun 10, 2019 · 7 comments
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue

Comments

@worthy7
Copy link

worthy7 commented Jun 10, 2019

Is your feature request related to a problem? Please describe.

I am trying to using MicrosoftAccount authentication but I need to force the user to select their account using the prompt=select_account parameters.

Describe the solution you'd like

When issuing a Challenge from the server, allow parameters to be added:
properties.Parameters.Add("prompt", "select_account");
This works with the google provider, it should also work with the Microsoft provider.

Describe alternatives you've considered

  1. Appending directly to the url, but I can't find a way to do this with the challenge object.
  2. making the option permanent in the startup config - but I only need it sometimes, so this isn't a good idea.

Additional context

I'm pretty confused why the Google provider is more comprehensive than the Microsoft one, Considering dot net is made by Microsoft...

@analogrelay analogrelay added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jun 10, 2019
@Tratcher
Copy link
Member

I'm pretty confused why the Google provider is more comprehensive than the Microsoft one

Because that feature was added to the Google provider by an external contributor.

Note you can do this with the OpenIdConnect handler.

@Tratcher Tratcher added enhancement This issue represents an ask for new feature or an enhancement to an existing one good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue labels Jun 10, 2019
@worthy7
Copy link
Author

worthy7 commented Jun 11, 2019

I haven't looked into the OpenIdConnect handler, but is it the same/an upgraded version of the MSAccount one?

@Tratcher
Copy link
Member

Yes, it's a bigger, more powerful, more generic, OAuth/OIDC handler.

@worthy7
Copy link
Author

worthy7 commented Jun 11, 2019 via email

@blowdart
Copy link
Contributor

That wouldn't be a bad approach at all :)

@Tratcher
Copy link
Member

It wouldn't be a derivation, it would be a replacement. We've considered obsoleting the OAuth providers that also have OIDC support like Google and MSA. We hadn't decided if we'd need a replacement or just a doc/sample using raw OIDC.

@worthy7
Copy link
Author

worthy7 commented Jun 12, 2019

Obsoleting the google and MS one's just means causing extra work for devs
+1 the idea of just replacing them, to avoid any breaking changes

@Tratcher Tratcher added the Done This issue has been fixed label Jun 12, 2019
@Tratcher Tratcher added this to the 3.0.0-preview7 milestone Jun 12, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

No branches or pull requests

4 participants