Skip to content

New linker incrementalism goes wrong when changing <BlazorLinkOnBuild> #18192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SteveSandersonMS opened this issue Jan 8, 2020 · 1 comment
Closed

New linker incrementalism goes wrong when changing <BlazorLinkOnBuild> #18192

SteveSandersonMS opened this issue Jan 8, 2020 · 1 comment
Assignees
@SteveSandersonMS
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in!
Milestone
blazor-wasm-3.2-p...

Comments

@SteveSandersonMS
Copy link
Member

Steps:

  • Have <BlazorLinkOnBuild>true</BlazorLinkOnBuild>
  • Perform a build
  • Switch to <BlazorLinkOnBuild>false</BlazorLinkOnBuild>
  • Change your code such that you now reference some BCL API that you didn't before
  • Build and run

Expected: since you have BlazorLinkOnBuild=false, you should be running against the unlinked assemblies and the app should work (although be very big)

Actual: it continues to use the linker output from the first build, and hence fails at runtime because the new BCL API you're now using was stripped out
@SteveSandersonMS SteveSandersonMS added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Jan 8, 2020
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Jan 8, 2020
@mkArtakMSFT mkArtakMSFT added this to the next milestone triage milestone Jan 8, 2020
SteveSandersonMS added a commit that referenced this issue Jan 9, 2020
@SteveSandersonMS
Allow overwriting outputs with older inputs. Fixes #18192
9082ec3
SteveSandersonMS added a commit that referenced this issue Jan 10, 2020
@SteveSandersonMS
Allow overwriting outputs with older inputs. Fixes #18192
cb09225
@SteveSandersonMS
Copy link
Member Author

Fixed in #18234

@SteveSandersonMS SteveSandersonMS added ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! Done This issue has been fixed labels Jan 10, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in!
Projects
None yet
Milestone
blazor-wasm-3.2-preview1
Development

No branches or pull requests
2 participants
@SteveSandersonMS @mkArtakMSFT