Skip to content

[dotnet-watch] Host MSBuild in-process instead of shelling out #31217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranavkm opened this issue Mar 25, 2021 · 3 comments
Open

[dotnet-watch] Host MSBuild in-process instead of shelling out #31217

pranavkm opened this issue Mar 25, 2021 · 3 comments
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external)
Milestone

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Mar 25, 2021

This has a few advantages including possibly faster builds in a rude edit, as well as a more robust API to interact with MSBuild

Things to do as part of this:

  • Update scoped css support to query MSBuild project system about what the generated file looks like
  • Updated static files support to query MSBuild for what the paths would look like rather than constructing it manually
@pranavkm pranavkm added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Mar 25, 2021
@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Mar 25, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Mar 25, 2021
@ghost
Copy link

ghost commented Mar 25, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@pranavkm
Copy link
Contributor Author

Notes from @ladipro's work: dotnet/msbuild#6254
The actual changes were done in: dotnet/sdk#16577

@ghost
Copy link

ghost commented Jun 15, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@mkArtakMSFT mkArtakMSFT added the feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external)
Projects
None yet
Development

No branches or pull requests

2 participants