HTTPSysServer does not use LoggerMessage.Define

[davidfowl]

Describe the bug

LoggerMessage.Define is the preferred approach to logging as it saves re-parsing format strings and doing dictionary lookups (and potential allocations if the cache isn't full). We should update the log calls to use it.

cc @sebastienros

[martincostello]

Happy to pick this up if you've not already started on it.

[davidfowl]

Sounds good. Are you aware of the latest pattern we've been using? It's a nested static Log class with static methods that do logging. If the class is big enough we make a partial class and put the log methods in there m. If that's not clear, take a look at SignalR

[martincostello]

I took a look at the repo and saw that there's a class called LoggingExtensions (example) and then the messages are defined in there.

If you're moving to nested per-class instead I'll do it that way instead 👍

[davidfowl]

E.g.

aspnetcore/src/Servers/IIS/IIS/src/Core/IISHttpContext.Log.cs

Line 12 in 155f402

private static class Log

aspnetcore/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/SendUtils.cs

Line 112 in 46359cd

private static class Log

[davidfowl]

Assigned the issue to you @martincostello