Skip to content

Fix Caching_SendFileWithFullContentLength_Cached() #32853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougbu opened this issue May 19, 2021 · 1 comment · Fixed by #36430
Closed

Fix Caching_SendFileWithFullContentLength_Cached() #32853

dougbu opened this issue May 19, 2021 · 1 comment · Fixed by #36430
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented May 19, 2021

Error Message

Assert.Equal() Failure
↓ (pos 0)
Expected: 1
Actual:   2
↑ (pos 0)

Stacktrace

at Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.ResponseCachingTests.Caching_SendFileWithFullContentLength_Cached() in /_/src/Servers/HttpSys/test/FunctionalTests/ResponseCachingTests.cs:line 401
--- End of stack trace from previous location ---

Build

https://dev.azure.com/dnceng/public/_build/results?buildId=1141411

Notes

Note the changes in #32508 (the PR validated in that build) are incredibly unlikely to cause unreliability in that test. At least anecdotally (per @Tratcher), the test is not reliable. That makes sense when other tests are contending for HTTP connections or otherwise slowing down when the test gets back to issuing its second GetFileAsync(...) call. May need more than a bump to the max-age=10 in the Cache-Control header.

dougbu added a commit that referenced this issue May 19, 2021
- see #32853
- also see if tripling `max-age` helps (which in quarantine)
@BrennanConroy BrennanConroy added this to the Next sprint planning milestone May 21, 2021
@ghost
Copy link

ghost commented May 21, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants