Skip to content

Improve readiness check for template tests #36224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiercn opened this issue Sep 7, 2021 · 1 comment
Closed

Improve readiness check for template tests #36224

javiercn opened this issue Sep 7, 2021 · 1 comment
Labels
area-blazor Includes: Blazor, Razor Components

Comments

@javiercn
Copy link
Member

javiercn commented Sep 7, 2021

We check on the title when we are determining whether the page is ready to continue. This is not ideal since since the title value now changes.

We could use a JS initializer that we drop on the test project to help us switch to a model where we are able to determine that the page is ready without relying on the title.
@javiercn javiercn mentioned this issue Sep 7, 2021
Merged
@javiercn javiercn added the area-blazor Includes: Blazor, Razor Components label Sep 7, 2021
@javiercn
Copy link
Member Author

javiercn commented Sep 7, 2021

Ended up addressing it inline #36088

@javiercn javiercn closed this as completed Sep 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javiercn