Skip to content

[Blazor] Update npm dependencies #36088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Sep 8, 2021
Merged

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Sep 2, 2021

Updates our NPM dependencies and upgrades the auth projects to use webpack5 inline with the rest of the Blazor projects

@javiercn javiercn requested a review from a team as a code owner September 2, 2021 10:00
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Sep 2, 2021
@javiercn javiercn requested a review from a team as a code owner September 3, 2021 10:27
@javiercn javiercn force-pushed the javiercn/blazor-update-npm-dependencies branch from cf5c289 to a215d17 Compare September 3, 2021 10:59
@javiercn javiercn requested a review from Pilchie as a code owner September 3, 2021 15:18
@javiercn
Copy link
Member Author

javiercn commented Sep 7, 2021

🆙📅

@SteveSandersonMS SteveSandersonMS self-requested a review September 7, 2021 17:30
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look great!

Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor items

@TanayParikh
Copy link
Contributor

Just tried out this branch locally, and it's seems to have fixed a lot of the random issues I was seeing with the Wasm.Authentication testassets! 🥇

@javiercn javiercn merged commit c1d16e3 into main Sep 8, 2021
@javiercn javiercn deleted the javiercn/blazor-update-npm-dependencies branch September 8, 2021 09:30
@ghost ghost added this to the 7.0-preview1 milestone Sep 8, 2021
@javiercn
Copy link
Member Author

javiercn commented Sep 8, 2021

/backport to release/6.0-rc1

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1212823832

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

@javiercn backporting to release/6.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update packages
Applying: Update codebase for new typescript errors
Applying: Update dependencies
Applying: update WebAssembly.Authentication npm packages
Applying: Update webassembly
Applying: Integrate with the build
Applying: Update build process for MSAL
Applying: Update msal-browser version
Applying: Partially fix errors
Applying: Update and fix test project
Applying: Update npm dependencies
Applying: Remove unnecessary dependency
Applying: Update JS files
warning: Cannot merge binary files: src/Components/Web.JS/dist/Release/blazor.webview.js (HEAD vs. Update JS files)
warning: Cannot merge binary files: src/Components/Web.JS/dist/Release/blazor.server.js (HEAD vs. Update JS files)
Using index info to reconstruct a base tree...
M	src/Components/Web.JS/dist/Release/blazor.server.js
M	src/Components/Web.JS/dist/Release/blazor.webview.js
Falling back to patching base and 3-way merge...
Auto-merging src/Components/Web.JS/dist/Release/blazor.webview.js
CONFLICT (content): Merge conflict in src/Components/Web.JS/dist/Release/blazor.webview.js
Auto-merging src/Components/Web.JS/dist/Release/blazor.server.js
CONFLICT (content): Merge conflict in src/Components/Web.JS/dist/Release/blazor.server.js
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0013 Update JS files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@javiercn
Copy link
Member Author

javiercn commented Sep 8, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1212836726

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

@javiercn backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update packages
Applying: Update codebase for new typescript errors
Applying: Update dependencies
Applying: update WebAssembly.Authentication npm packages
Applying: Update webassembly
Applying: Integrate with the build
Applying: Update build process for MSAL
Applying: Update msal-browser version
Applying: Partially fix errors
Applying: Update and fix test project
Applying: Update npm dependencies
Applying: Remove unnecessary dependency
Applying: Update JS files
warning: Cannot merge binary files: src/Components/Web.JS/dist/Release/blazor.webview.js (HEAD vs. Update JS files)
warning: Cannot merge binary files: src/Components/Web.JS/dist/Release/blazor.server.js (HEAD vs. Update JS files)
Using index info to reconstruct a base tree...
M	src/Components/Web.JS/dist/Release/blazor.server.js
M	src/Components/Web.JS/dist/Release/blazor.webview.js
Falling back to patching base and 3-way merge...
Auto-merging src/Components/Web.JS/dist/Release/blazor.webview.js
CONFLICT (content): Merge conflict in src/Components/Web.JS/dist/Release/blazor.webview.js
Auto-merging src/Components/Web.JS/dist/Release/blazor.server.js
CONFLICT (content): Merge conflict in src/Components/Web.JS/dist/Release/blazor.server.js
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0013 Update JS files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

javiercn added a commit that referenced this pull request Sep 8, 2021
* Updates npm dependencies to their latest versions.
* Standardizes build process for our JS dependencies on webpack 5 with babel, etc.
* Updates dependencies for the auth packages to their latest versions.
* Fixes test assets so that they can be run locally.
wtgodbe pushed a commit that referenced this pull request Sep 8, 2021
* Updates npm dependencies to their latest versions.
* Standardizes build process for our JS dependencies on webpack 5 with babel, etc.
* Updates dependencies for the auth packages to their latest versions.
* Fixes test assets so that they can be run locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants