Skip to content

IISIntegration tests in VS don't detect changes #40387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
HaoK opened this issue Feb 24, 2022 · 5 comments
Closed
1 task done

IISIntegration tests in VS don't detect changes #40387

HaoK opened this issue Feb 24, 2022 · 5 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@HaoK
Copy link
Member

HaoK commented Feb 24, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Note: I don't think release is required, but I've primarily been debugging/running in release due to some ANCM tests only working in release

I'm using VS2022 17.1.0/against main branch (with IIS installed + Admin powershell)

  1. git clean -xdff/restore.cmd/activate.ps1
  2. cd src/Servers/IIS
  3. build.cmd -c Release
  4. startvs.cmd / switch to Release/x64 platform
  5. Wait for test explorer to load all the tests, then go to Microsoft.AspNetCore.Server.IIS.NewShim.FunctionalTests.StartupTests.CheckInvalidHostingModelParameter
  6. Double click on test to open StartupTests.cs (C:\Github\aspnetcore\src\Servers\IIS\IIS\test\Common.LongTests\StartupTests.cs)
  7. Comment out the [SkipNonHelix("https://github.com/dotnet/aspnetcore/issues/25107")] on line 41
  8. Run the test, notice that nothing builds as things are considered up to date and yet still is skipped.
  9. Add <DisableFastUpToDateCheck>True</DisableFastUpToDateCheck> to src\Servers\IIS\IIS\test\IIS.NewShim.FunctionalTests\IIS.NewShim.FunctionalTests.csproj
  10. Run the test and notice it rebuilds and the test is no longer skipped.

I'm guessing this is might be due to StartupTests is being a file included from shared tests
<Compile Include="..\Common.LongTests\**\*.cs" />
`

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@Pilchie Pilchie self-assigned this Feb 24, 2022
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 24, 2022
@mkArtakMSFT mkArtakMSFT added area-runtime and removed area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Dec 13, 2022
@mkArtakMSFT
Copy link
Contributor

Moving this to the area-runtime as this seems very specific to this project.

@halter73
Copy link
Member

@HaoK Do you know how to fix this? Should we just add the <DisableFastUpToDateCheck>True</DisableFastUpToDateCheck> to the csproj?

@HaoK
Copy link
Member Author

HaoK commented Dec 15, 2022

Yeah that was how it was before I believe but Kevin wanted us to do a pass to remove that and increase the build perf...

@Pilchie
Copy link
Member

Pilchie commented Dec 15, 2022

Could definitely just re-add the <DisableFastUpToDateCheck>true</> if you don't want to dig in. Possible that @dougbu already fixed this issue in 9a431ee though.

@adityamandaleeka
Copy link
Member

I think this can be closed. These projects have DisableFastUpToDateCheck enabled already (e.g. https://github.com/dotnet/aspnetcore/blob/main/src/Servers/IIS/IIS/test/IIS.NewShim.FunctionalTests/IIS.NewShim.FunctionalTests.csproj#L8).

I also checked that, if that setting is removed, the skip detection does get correctly picked up between invocations of the test from test explorer (i.e. the incremental build scenario).

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

No branches or pull requests

8 participants
@halter73 @adityamandaleeka @Pilchie @HaoK @amcasey @mkArtakMSFT and others