Skip to content

Resolve cyclic dependencies between Http.Results and Http.Extensions #41330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
captainsafia opened this issue Apr 22, 2022 · 1 comment
Open
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
Milestone

Comments

@captainsafia
Copy link
Member

captainsafia commented Apr 22, 2022

To support users being able to determine if the handler they are wrapping a filter is a void-returning handler, we need to add support for returning the EmptyHttpResult from the filter pipeline. However, do to cyclic dependencies we cannot use the defined EmptyHttpResult type. This prevents users from being able to assert on the type.

@captainsafia captainsafia added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Apr 22, 2022
@davidfowl
Copy link
Member

One thing we can do is move results down and then typeforward them.

@rafikiassumani-msft rafikiassumani-msft added this to the 7.0-preview6 milestone Apr 26, 2022
@brunolins16 brunolins16 removed their assignment Feb 24, 2023
@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Jun 20, 2023
@captainsafia captainsafia modified the milestones: .NET 8 Planning, Backlog Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
Projects
None yet
Development

No branches or pull requests

4 participants