Move EmptyHttpResult to Http.Abstractions #46077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
the
old-area-web-frameworks-do-not-use
JamesNK
requested review from
javiercn,
Tratcher,
BrennanConroy and
halter73
as code owners
ghost
added
the
|
This change resolves: #41330 Overall, I'm fine with moving only the problematic type lower. I don't think there's other HttpResult types that need the same treatment. Does this need an API review or does the type forward mitigate that? |
From the user's perspective, nothing changes. Doesn't seem necessary. What do you think @halter73? |
halter73
approved these changes
Jan 13, 2023
|
This is a nonbreaking change that doesn't really add API. I don't think we have to API review type forwards. The only thing to discuss would be the assembly to move it to. I think normal PR review is sufficient. |
|
Numbers!
And no more warnings from |
davidfowl
approved these changes
Jan 13, 2023
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
EmptyHttpResultto abstractions and adds a type forward. This allows us to no longer require reflection hacks to get a reference toEmptyHttpResult.Empty.IMO this isn't just a change to make our code better. It is normal to have a "null" or "empty" value/implementation be part of the abstraction.