Reduce record usage in published aspnetcore projects

[JamesNK]

records have a slim syntax and provide many features, but they also generate a lot of code. And much of that code can't be trimmed. A record can bloat app publish size.

See #45604 (comment) for an example.

• Audit published aspnetcore projects for record usage. records in test projects is fine.
• See if there is an analyzer that we can enable to warn about record use, and enable.

[JamesNK]

@eerhardt Part of publish size effort.

[ghost]

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[brunolins16]

Those are all places where record is used in our repo, not including tests and analyzers.

MVC.Core

aspnetcore/src/Mvc/Mvc.Core/src/ModelBinding/Binders/CollectionModelBinder.cs

Line 405 in 493407b

internal sealed record CollectionResult(IEnumerable<TElement?> Model)

Kestrel

aspnetcore/src/Servers/Kestrel/Core/src/Internal/Infrastructure/HttpUtilities.cs

Line 601 in 493407b

internal sealed record AltSvcHeader(string Value, byte[] RawBytes);

aspnetcore/src/Servers/Kestrel/shared/KnownHeaders.cs

Line 50 in 493407b

public record InternalHeader(string Identifier, string Name, bool IsPseudoHeader = false);

aspnetcore/src/Servers/Kestrel/Transport.Quic/src/Internal/QuicStreamContext.FeatureCollection.cs

Line 18 in 493407b

private readonly record struct OnCloseRegistration(Action<object?> Callback, object? State);

Routing

aspnetcore/src/Http/Routing/src/Matching/DfaMatcherBuilder.cs

Line 943 in 493407b

private readonly record struct DfaBuilderWorkerWorkItem(RouteEndpoint Endpoint, int PrecedenceDigit, List<DfaNode> Parents);

Components

aspnetcore/src/Components/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs

Line 258 in 493407b

internal record struct InternalAccessTokenResult([property: JsonConverter(typeof(JsonStringEnumConverter))] AccessTokenResultStatus Status, AccessToken Token);

aspnetcore/src/Components/WebView/WebView/src/Services/WebViewRenderer.cs

Line 79 in 493407b

private sealed record UnacknowledgedRenderBatch

aspnetcore/src/Components/WebAssembly/WebAssembly.Authentication/src/Models/InteractiveRequestOptions.cs

Line 118 in 493407b

internal record struct OptionsRecord(

Grpc

aspnetcore/src/Grpc/JsonTranscoding/src/Shared/ServiceDescriptorHelpers.cs

Line 447 in 493407b

public sealed record BodyDescriptorInfo(

aspnetcore/src/Grpc/JsonTranscoding/src/Shared/ServiceDescriptorHelpers.cs

Line 511 in 493407b

internal record RouteParameter(

Shared (Probably used in tests)

aspnetcore/src/Shared/BrowserTesting/src/BrowserManagerConfiguration.cs

Line 357 in 493407b

public record BrowserOptions(BrowserKind BrowserKind, BrowserTypeLaunchOptions BrowserLaunchOptions, BrowserNewContextOptions DefaultContextOptions);

aspnetcore/src/Shared/BrowserTesting/src/PageInformation.cs

Line 119 in 493407b

public record LogEntry(string Message, string Level);

[mitchdenny]

@eerhardt @captainsafia where do you think this sits in terms of priority right now. I think the work is still valid, but perhaps a lower priority for now?

[eerhardt]

Yeah, it's pretty low on the priority list IMO. The only case that I would think is high priority is to ensure we don't ship any "new" public record types in .NET 8. If there are ones we added in 8, making them normal classes would be important.

[danmoseley]

would we take community changes for it - should it be 'help wanted' - or not a good candidate?

[captainsafia]

Agree that this is a good candidate for help wanted!

I've gone ahead and updated @brunolins16's comment to reflect the the fact that records were removed from RDG so the listi s more accurate for contributors.

[david-acker]

Here are some other record types that I found in the project (excluding those in analyzer, test, and tools code):

Microsoft.AspNetCore.Components

aspnetcore/src/Components/Components/src/ComponentFactory.cs

Lines 123 to 125 in e1f6684

	private record class ComponentTypeInfoCacheEntry(
	IComponentRenderMode? ComponentTypeRenderMode,
	Action<IServiceProvider, IComponent> PerformPropertyInjection);

aspnetcore/src/Components/Endpoints/src/Binding/Factories/ComplexType/ComplexTypeExpressionConverterFactoryOfT.cs

Lines 159 to 164 in e1f6684

	private record struct FormDataConverterReadParameters(
	ParameterExpression ReaderParam,
	ParameterExpression TypeParam,
	ParameterExpression OptionsParam,
	ParameterExpression ResultParam,
	ParameterExpression FoundValueParam);

aspnetcore/src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.cs

Line 251 in da8a6f0

private record struct NamedEvent(ulong EventHandlerId, int ComponentId, string EventNameId);

aspnetcore/src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.Streaming.cs

Line 248 in e1f6684

private readonly record struct ComponentIdAndDepth(int ComponentId, int Depth);

aspnetcore/src/Components/Web/src/Forms/ExpressionFormatting/ExpressionFormatter.cs

Line 266 in e1f6684

private record struct MethodInfoData(bool IsSingleArgumentIndexer);

aspnetcore/src/Components/WebAssembly/Server/src/TargetPickerUi.cs

Lines 428 to 436 in e1f6684

	private sealed record BrowserTab
	(
	string Id,
	string Type,
	string Url,
	string Title,
	string DevtoolsFrontendUrl,
	string WebSocketDebuggerUrl
	);