Skip to content

Add validation to test that OOB packages have no SharedFx-only references #50402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wtgodbe opened this issue Aug 29, 2023 · 3 comments
Open
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Milestone

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Aug 29, 2023

We had a situation in 8.0 where Microsoft.Extensions.Caching.StackExchangeRedis (which is an OOB package) added a dependency on Microsoft.AspNetCore.OutputCaching (which is SharedFx-only), which caused StackExchangeRedis to have a FrameworkReference on AspNetCore.App. This means devs using StackExchangeRedis would need to have Asp.Net installed on their machine in order to use the package, which goes against the principle of an OOB package (they should be useable by non-asp.net devs). We should add validation, maybe in ResolveReferences.targets, that prevents this from happening again, as it's a very easy mistake to make.

@wtgodbe wtgodbe added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 29, 2023
@wtgodbe wtgodbe added this to the .NET 9 Planning milestone Aug 29, 2023
@wtgodbe wtgodbe self-assigned this Aug 29, 2023
@ghost
Copy link

ghost commented Aug 29, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@Tratcher
Copy link
Member

This issue only applies to Extensions, right? Note all of the Authentication OOB packages do require the shared framework.

@wtgodbe
Copy link
Member Author

wtgodbe commented Aug 29, 2023

This issue only applies to Extensions, right? Note all of the Authentication OOB packages do require the shared framework.

Oh, I didn't know that. If that's the case then yeah, seems like this should only apply to Extensions

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@wtgodbe wtgodbe modified the milestones: .NET 9 Planning, Backlog Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

2 participants