Skip to content

Fix skipped redis unit tests #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrennanConroy opened this issue Oct 8, 2018 · 5 comments · Fixed by #32601
Closed

Fix skipped redis unit tests #5345

BrennanConroy opened this issue Oct 8, 2018 · 5 comments · Fixed by #32601
Labels
affected-medium This issue impacts approximately half of our customers area-signalr Includes: SignalR clients and servers severity-minor This label is used by an internal tool task test-failure
Milestone
6.0-preview5

Comments

@BrennanConroy
Copy link
Member

Updating to 2.X.X of StackExchange,Redis broke the unit tests because we can't properly mock the ISubscriber class.

This is for tracking StackExchange/StackExchange.Redis#969 and fixing our unit tests once a fix has been made.
@BrennanConroy
Copy link
Member Author

Also re-enable RedisHubLifetimeManagerBenchmark

@analogrelay
Copy link
Contributor

We should just work around this by wrapping all the way down.

@aspnet-hello aspnet-hello transferred this issue from aspnet/SignalR Dec 17, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Dec 17, 2018
@aspnet-hello aspnet-hello added area-signalr Includes: SignalR clients and servers cost: S labels Dec 17, 2018
@bradygaster bradygaster modified the milestones: 3.0.0, Backlog Feb 6, 2019
@mikaelm12 mikaelm12 mentioned this issue Feb 11, 2019
Closed
@analogrelay analogrelay added task blocked The work on this issue is blocked due to some dependency and removed type: Task blocked The work on this issue is blocked due to some dependency labels Mar 21, 2019
@analogrelay analogrelay modified the milestones: Backlog, 3.1.0-preview2 Sep 17, 2019
@analogrelay
Copy link
Contributor

This is basically a 95% test fix, but we may need to flow a new abstraction through the product code to make it feasible. We'll get the fix ready and see how tactics feels.

@Pilchie
Copy link
Member

Pilchie commented Oct 31, 2019

@anurse is this still happening? It's in the preview2 milestone and unassigned.

@analogrelay
Copy link
Contributor

Nope, I'll unmilestone it and we'll schedule for 5.0 (and backport if we feel we need the coverage in 3.1.x).

@analogrelay analogrelay removed this from the 3.1.0-preview2 milestone Oct 31, 2019
@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Nov 7, 2019
@analogrelay analogrelay modified the milestones: 5.0.0-preview1, Backlog Mar 11, 2020
@pranavkm pranavkm removed the cost: S label Nov 6, 2020
@BrennanConroy BrennanConroy added affected-medium This issue impacts approximately half of our customers severity-minor This label is used by an internal tool labels Nov 10, 2020 — with ASP.NET Core Issue Ranking
@BrennanConroy BrennanConroy mentioned this issue May 11, 2021
Merged
@BrennanConroy BrennanConroy modified the milestones: Backlog, 6.0-preview5 May 13, 2021
@BrennanConroy BrennanConroy removed the blocked The work on this issue is blocked due to some dependency label May 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affected-medium This issue impacts approximately half of our customers area-signalr Includes: SignalR clients and servers severity-minor This label is used by an internal tool task test-failure
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging a pull request may close this issue.

Enable Redis unit tests dotnet/aspnetcore
7 participants
@analogrelay @pranavkm @Pilchie @BrennanConroy @ryanbrandenburg @aspnet-hello @bradygaster