Skip to content

Enable Redis unit tests #32601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2021
Merged

Enable Redis unit tests #32601

merged 4 commits into from
May 13, 2021

Conversation

BrennanConroy
Copy link
Member

Fixes #5345

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label May 11, 2021
@BrennanConroy BrennanConroy added this to the 6.0-preview5 milestone May 11, 2021
_subscriptions.AddOrUpdate(channel, _ => new List<Action<RedisChannel, RedisValue>> { handler }, (_, list) =>
Action<RedisChannel, RedisValue> handler = (channel, value) =>
{
// ChannelMessageQueue isn't mockable currently, this works around that by using private reflection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the issue both places we do the crazy private reflection.

@BrennanConroy BrennanConroy enabled auto-merge (squash) May 13, 2021 01:36
@BrennanConroy BrennanConroy merged commit d8906c8 into main May 13, 2021
@BrennanConroy BrennanConroy deleted the brecon/redistest branch May 13, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix skipped redis unit tests
2 participants