Published size regression: basicminimalapipublishaot, basicminimalapipublishaot, todosapipublishaot

[pr-benchmarks]

Scenario	Environment	Date	Old Build (KB)	New Build (KB)	Change	Deviation	StDev	Dependencies
basicminimalapipublishaot	Goldilocks Stage 1 (NativeAOT) 7- Native Aot Intel Windows	05/18/2024 00:46:35	52,846	55,582	5.00 % (2,736) 👎	228.00 σ	12	Changes Name Version Diff Microsoft.AspNetCore.App 9.0.0-preview.5.24256.2 -> 9.0.0-preview.5.24266.2 da3aa27...98c6c29 Microsoft.NETCore.App 9.0.0-preview.5.24256.1 -> 9.0.0-preview.5.24265.2 dotnet/runtime@84b3339...1f08a36
basicminimalapipublishaot	Goldilocks Stage 1 (NativeAOT - Server GC) 7- Native Aot Intel Windows	05/18/2024 00:47:38	52,846	55,581	5.00 % (2,735) 👎	227.00 σ	12	Changes Name Version Diff Microsoft.AspNetCore.App 9.0.0-preview.5.24256.2 -> 9.0.0-preview.5.24266.2 da3aa27...98c6c29 Microsoft.NETCore.App 9.0.0-preview.5.24256.1 -> 9.0.0-preview.5.24265.2 dotnet/runtime@84b3339...1f08a36
todosapipublishaot	Goldilocks Stage 2 (NativeAOT) 7- Native Aot Intel Windows	05/18/2024 00:52:14	101,451	106,261	4.00 % (4,810) 👎	167.01 σ	29	Changes Name Version Diff Microsoft.AspNetCore.App 9.0.0-preview.5.24256.2 -> 9.0.0-preview.5.24266.2 da3aa27...98c6c29 Microsoft.NETCore.App 9.0.0-preview.5.24256.1 -> 9.0.0-preview.5.24265.2 dotnet/runtime@84b3339...1f08a36

PowerBI Dashboard

@sebastienros
@eerhardt

[eerhardt]

This appears to be caused by #55558. Specifically by the usage of System.Linq over value types (in this case System.Double).

Comparing the before and after:

You can see that there is 53.5 kB of System.Linq code in the new code.

Expanding this:

And then seeing what is bringing that code in shows:

Which points to:

aspnetcore/src/Http/Routing/src/Matching/NegotiationMatcherPolicy.cs

Lines 287 to 290 in 94ad1d4

	result[index] = new PolicyNodeEdge(
	// Metadata quality is 0 for the edges that don't have metadata as we prefer serving from the endpoints that have metadata
	new NegotiationEdgeKey(kvp.Key, kvp.Value.Select(e => GetMetadataQuality(e) ?? 0).ToArray()),
	kvp.Value);

If we would eliminate the usage of System.Linq here, we would go back to (roughly) the size before the change.

cc @javiercn

[eerhardt]

BasicMinimalApi.mstat.zip

Attached is the mstat and dgml files that can be opened with https://github.com/MichalStrehovsky/sizoscope to see the above information.

[DamianEdwards]

Should we consider not including this matcher at all in the slim builder?