-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Helix] Enable Components.E2E tests #6857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This also appears to be an issue with ProjectTemplates.Test |
@HaoK is anybody tracking work to install selenium on the agents? |
/cc @ryanbrandenburg |
There's the corresponding issue https://github.com/dotnet/core-eng/issues/5302 The templates/components tests are currently failing due to other issues, so they are waiting for us to confirm if the existing queues now has everything we need. You can use #8256 to investigate the current project template helix failures, Components is blocked by the build issue #7862 |
@javiercn who recently changed this area. |
Selenium would need to be installed into the machine in the same way as its done in azure pipelines. You can use |
Who is going to take care of installation |
The helix team is helping us get everything we need installed on the machines on the queues, they just merged a set of changes for us I'll kick off a new run to see if we have everything we need now |
Getting closer, looks like selenium is a go, but its not properly configured, any ideas what we need to set here for the SeleniumProcessTrackingFolder?
|
Yeah, you need to setup an environment variable to a folder we can use for writing the PIDs of the processes we start. On the CI we set it to RepoRoot/obj in helix you can set it to any temp folder you feel like. We just need this to ensure we don’t leave processes running behind us. It’s also important to add a build step that reads the folder and kills each alive process that matches the files so that we don’t leave any folder behind. You can check the DevOps pipeline for a sample of what we do there. |
I don't think cleanup is as important on helix, everything should be getting automatically nuked after the work item is done by the helix infrastructure |
@HaoK As in the machine rebooted, image destroyed etc? Then just point it to an existing folder and that should be enough |
This is tracked by #31159 since we no longer plan to run the components/selenium e2e tests as is, but instead migrate things to playwright which will work on helix from the start |
Need to install selenium on helix machines?
The text was updated successfully, but these errors were encountered: