Skip to content

Consider adding a LazyResettableCts for Kestrel #9419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jkotalik opened this issue Apr 16, 2019 · 0 comments
Open

Consider adding a LazyResettableCts for Kestrel #9419

jkotalik opened this issue Apr 16, 2019 · 0 comments
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Milestone
Backlog

Comments

@jkotalik
Copy link
Contributor

We have been bitten in the past in Kestrel by making the RequestAborted token lazy. We have now had 3 attempts to fix our disposal of the RequestAborted token (e04c79b, 0622513, and another one from a while ago that I can't find), and though we think our logic is correct now, it isn't easy to guarantee and verify.

A nice way to simplify this logic is to create a new CTS type that is both lazy and resettable. Internally, it would handle races between calling cancel and dispose and be resettable.
@jkotalik jkotalik mentioned this issue Apr 16, 2019
Merged
@analogrelay analogrelay added this to the Backlog milestone Apr 16, 2019
@pranavkm pranavkm removed the cost: S label Nov 6, 2020
@jkotalik jkotalik added affected-very-few This issue impacts very few customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@analogrelay @pranavkm @jkotalik @amcasey