Skip to content

Avoid throwing if serializer settings is null #12207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Avoid throwing if serializer settings is null #12207

merged 1 commit into from
Jul 16, 2019

Conversation

pranavkm
Copy link
Contributor

Also adds some docs that suggest what needs to be passed as an argument instance

@pranavkm
Avoid throwing if serializer settings is null
633458a 
Also adds some docs that suggest what needs to be passed as an argument instance
@pranavkm pranavkm requested a review from rynowak July 15, 2019 22:25
@pranavkm
Copy link
Contributor Author

cc @NickCraver

NickCraver
NickCraver approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes - thank you!

@mkArtakMSFT mkArtakMSFT added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 15, 2019
@pranavkm pranavkm merged commit 94edcbf into master Jul 16, 2019
@NickCraver NickCraver mentioned this pull request Jul 17, 2019
Closed
@pranavkm pranavkm deleted the prkrishn/fixup-nulls branch July 30, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @NickCraver @rynowak @mkArtakMSFT