-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Revert "Revert "Improve components infrastructure (#12145)" (#12679)" #12744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has anything changed in this since the original PR? If yes, where should we dive deeper?
ea1bc88
to
4034ec2
Compare
|
I'm going to update with a few more details on how I intend for this to work when all tests come back clean but I believe this is close to ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good.
Here's a few of the common scenarios and how it will work when you run build by default (i.e. without specifying BuildNodeJs or NoBuildNodeJS):
With explicit specification of BuildNodeJs: With explicit specification of NoBuildNodeJs: |
@rynowak, @pranavkm calls your |
Dank. |
This reverts commit e2d57e2.
As per meeting discussion, this is the approach we would like to take for source build as well. However, there will likely be pieces of the infrastructure that needs to be modified (e.g. not redistributing yarn binaries) but we'll address those separately.
I'm adding the original changes to preview 9 for improving workflow.