Skip to content

fix npm flake #13106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2019
Merged

fix npm flake #13106

merged 3 commits into from
Aug 14, 2019

Conversation

JunTaoLuo
Copy link
Contributor

Thanks @BrennanConroy for the fix!

@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Aug 13, 2019
@JunTaoLuo JunTaoLuo added this to the 3.0.0-preview9 milestone Aug 13, 2019
@JunTaoLuo JunTaoLuo mentioned this pull request Aug 13, 2019
Closed
@wtgodbe
Copy link
Member

wtgodbe commented Aug 13, 2019

The change to blazor.server.js is equivalent to what I got in #12977, I'm curious to see what happens with CodeCheck here

@BrennanConroy
Copy link
Member

John and I took a look at it and it makes sense why it was different

@JunTaoLuo
Copy link
Contributor Author

The version number burned into the .js file requires more discussion. Disabling the codecheck step for that file to unblock builds but we need a better solution. Will send out an email to discuss this.

@BrennanConroy BrennanConroy merged commit ed360e1 into release/3.0 Aug 14, 2019
@ghost ghost deleted the johluo/fix-npm-flake branch August 14, 2019 14:48
@BrennanConroy
Copy link
Member

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=308659&view=logs

@wtgodbe wtgodbe mentioned this pull request Aug 14, 2019
Merged
@BrennanConroy BrennanConroy mentioned this pull request Sep 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
3.0.0-preview9
Development

Successfully merging this pull request may close these issues.
4 participants
@JunTaoLuo @wtgodbe @BrennanConroy @dougbu