[3.0] Skip known failure in ShutdownTestWaitForShutdown

[Tratcher]

3.0 Test only change. https://github.com/aspnet/AspNetCore-Internal/issues/2577

A 3.0 CLR regression caused ShutdownTestRun to fail most of the time so we skipped it a while ago. ShutdownTestWaitForShutdown only fails once in awhile. We aren't expecting a CLR fix until 3.1 so this test should also be permanently skipped in 3.0.

[analogrelay]

Things are pretty locked down for 3.0.1, so I think we should wait for 3.0.2 to take this change (just to avoid any churn in builds at all). Thoughts @dougbu ? Disabling a test is pretty safe but also not necessarily critical to ship (unless that test is blocking us :))

[dougbu]

Looks like at least #14425 remains blocked. Meaning @Tratcher may be able to get this in once it builds. @wtgodbe your thoughts?

[analogrelay]

If the test is blocking 3.0.1 builds (or is likely to do so) I certainly have no problem taking it in 3.0.1 (as long as that won't jeopardize getting a candidate build).

[dougbu]

Failures in validation build when creating installers don't look great. Did something get merged into 'release/3.0' without validation? @wtgodbe this looks like a problem w/ your <icon> fixes and I'm surprised 3.0 builds are progressing.

  The element 'metadata' in namespace 'http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd' has invalid child element 'icon' in namespace 'http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd'. List of possible elements expected: 'frameworkReferences, dependencies, frameworkAssemblies, license, repository, releaseNotes, requireLicenseAcceptance, contentFiles, iconUrl, description, developmentDependency, serviceable, summary, packageTypes, copyright, references, tags, language' in namespace 'http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd'. This validation error occurred in a 'icon' element.
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073: The command "powershell -NoProfile -NoLogo F:\workspace\_work\1\s\\src\Installers\Windows\GenerateNugetPackageWithMsi.ps1 ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       'AspNetCore.TargetingPack' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       'F:\workspace\_work\1\s\artifacts\installers\Release\aspnetcore-targeting-pack-3.0.1-ci-win-x86.msi' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       '' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       'F:\workspace\_work\1\s\\src\Installers\Windows\TargetingPack\TargetingPackPackage.nuspec' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       'F:\workspace\_work\1\s\artifacts\packages\Release\NonShipping\' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       'x86' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       '3.0.1-ci' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       'F:\workspace\_work\1\s\' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       '3' ^
F:\workspace\_work\1\s\src\Installers\Windows\TargetingPack\TargetingPack.wixproj(94,5): error MSB3073:                       '0'" exited with code 1.

---

@JunTaoLuo please clean up the following warnings. This kind of output makes it more difficult to find real errors:

F:\workspace\_work\1\s\.dotnet\sdk\3.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5131: - Add Microsoft.Extensions.FileProviders.Composite.xml to the netcoreapp3.0 reference group in the nuspec [F:\workspace\_work\1\s\src\Framework\ref\Microsoft.AspNetCore.App.Ref.csproj]
F:\workspace\_work\1\s\.dotnet\sdk\3.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5131: - Add Microsoft.Extensions.FileProviders.Embedded.xml to the netcoreapp3.0 reference group in the nuspec [F:\workspace\_work\1\s\src\Framework\ref\Microsoft.AspNetCore.App.Ref.csproj]
F:\workspace\_work\1\s\.dotnet\sdk\3.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5131: - Add Microsoft.Extensions.FileProviders.Physical.xml to the netcoreapp3.0 reference group in the nuspec [F:\workspace\_work\1\s\src\Framework\ref\Microsoft.AspNetCore.App.Ref.csproj]
F:\workspace\_work\1\s\.dotnet\sdk\3.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5131: - Add Microsoft.Extensions.FileSystemGlobbing.xml to the netcoreapp3.0 reference group in the nuspec [F:\workspace\_work\1\s\src\Framework\ref\Microsoft.AspNetCore.App.Ref.csproj]
F:\workspace\_work\1\s\.dotnet\sdk\3.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5131: - Add Microsoft.Extensions.Hosting.Abstractions.xml to the netcoreapp3.0 reference group in the nuspec
...

The number of warnings about missing / extra placeholders isn't good either @wtgodbe e.g.

F:\workspace\_work\1\s\.dotnet\sdk\3.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below: [F:\workspace\_work\1\s\src\Analyzers\shared\FeatureDetection\Microsoft.AspNetCore.Analyzers.FeatureDetection.Sources.csproj]
F:\workspace\_work\1\s\.dotnet\sdk\3.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5128: - Add lib or ref assemblies for the netstandard1.0 target framework [F:\workspace\_work\1\s\src\Analyzers\shared\FeatureDetection\Microsoft.AspNetCore.Analyzers.FeatureDetection.Sources.csproj]

[dougbu]

@wtgodbe errors occurred in your PR for the icon change: https://github.com/aspnet/AspNetCore/pull/14394/checks?check_run_id=248339536 But, they didn't cause the jobs to fail and that's bad -- very bad. Any ideas?

[dougbu]

Don't think there's anything neewer in the 'release/3.0' branch that'll help here. But, closing / reopening to recreate the tested branch

[Tratcher]

@dougbu please merge.