-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Link more assemblies (type granularity linking for real this time) #18165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveSandersonMS
merged 8 commits into
blazor-wasm
from
stevesa/type-granularity-linking-for-real
Jan 10, 2020
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
15705ef
Make apps smaller via type-granularity linking
SteveSandersonMS eb47df7
Generate the typegranularity linker config based on referenced assemb…
SteveSandersonMS 6d8a654
Fix
SteveSandersonMS 1fefa90
Pre-filter the assembly list when calling GenerateTypeGranularityLink…
SteveSandersonMS 1e94281
CR feedback
SteveSandersonMS 30926f6
CR: Switch to use XElement
SteveSandersonMS 63f3516
Super minor tweak
SteveSandersonMS 60b6f24
Update src/Components/Blazor/Build/src/targets/Blazor.MonoRuntime.tar…
SteveSandersonMS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/Components/Blazor/Build/src/Tasks/GenerateTypeGranularityLinkingConfig.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// Copyright (c) .NET Foundation. All rights reserved. | ||
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
||
using System.IO; | ||
using System.Xml.Linq; | ||
using Microsoft.Build.Framework; | ||
using Microsoft.Build.Utilities; | ||
|
||
namespace Microsoft.AspNetCore.Blazor.Build.Tasks | ||
{ | ||
public class GenerateTypeGranularityLinkingConfig : Task | ||
{ | ||
[Required] | ||
public ITaskItem[] Assemblies { get; set; } | ||
|
||
[Required] | ||
public string OutputPath { get; set; } | ||
|
||
public override bool Execute() | ||
{ | ||
var linkerElement = new XElement("linker", | ||
new XComment(" THIS IS A GENERATED FILE - DO NOT EDIT MANUALLY ")); | ||
|
||
foreach (var assembly in Assemblies) | ||
{ | ||
var assemblyElement = CreateTypeGranularityConfig(assembly); | ||
linkerElement.Add(assemblyElement); | ||
} | ||
|
||
using var fileStream = File.Open(OutputPath, FileMode.Create); | ||
new XDocument(linkerElement).Save(fileStream); | ||
|
||
return true; | ||
} | ||
|
||
private XElement CreateTypeGranularityConfig(ITaskItem assembly) | ||
{ | ||
// We match all types in the assembly, and for each one, tell the linker to preserve all | ||
// its members (preserve=all) but only if there's some reference to the type (required=false) | ||
return new XElement("assembly", | ||
new XAttribute("fullname", Path.GetFileNameWithoutExtension(assembly.ItemSpec)), | ||
new XElement("type", | ||
new XAttribute("fullname", "*"), | ||
new XAttribute("preserve", "all"), | ||
new XAttribute("required", "false"))); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.