Fix ANCM search for dotnet.exe

[newbienewbie]

• Change to IsDotnetExecutable() to determine by the filename instead of by ends_with()
• add an Unit Test

Addresses #17393 (It was caused by this line:

return ends_with(dotnetPath, L"dotnet.exe", true);

[jkotalik]

Wow, great PR. Besides making sure this passes, LGTM.

[newbienewbie]

@jkotalik sorry, I don't know why aspnet-core-ci fails to build.
https://dev.azure.com/dnceng/public/_build/results?buildId=481298&view=results

How to see the error info?

[jkotalik]

I think there is an outage. Let me try retriggering it.

[jkotalik]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[newbienewbie]

The CI still fails to build 😢

I see the the step Install Node 10.x on Ubuntu fails:

Starting: Install Node 10.x
==============================================================================
Task         : Node.js tool installer
Description  : Finds or downloads and caches the specified version spec of Node.js and adds it to the PATH
Version      : 0.159.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/tool/node-js
==============================================================================
Downloading: https://nodejs.org/dist/v10.18.1/node-v10.18.1-linux-x64.tar.gz
Extracting archive
/bin/tar xzC /home/vsts/work/_temp/5431baa6-da51-4e67-8d0b-e4594e61e66e -f /home/vsts/work/_temp/b525ccf0-7974-4f6f-9831-43575c7de9c1

gzip: stdin: unexpected end of file
/bin/tar: Child returned status 1
/bin/tar: Error is not recoverable: exiting now
##[error]/bin/tar failed with return code: 2
Finishing: Install Node 10.x

And the step Run build.cmd on Windows Server2016 x64 complains:

F:\workspace\_work\1\s\eng\targets\Npm.Common.targets(122,5): error : Command failed with exit code 1. [F:\workspace\_work\1\s\src\SignalR\clients\ts\client-ts.npmproj]
##[error]eng\targets\Npm.Common.targets(122,5): error : Command failed with exit code 1.

...


ERROR: The process "testhost.exe" not found.
ERROR: The process "iisexpress.exe" not found.
ERROR: The process "iisexpresstray.exe" not found.
ERROR: The process "w3wp.exe" not found.
ERROR: The process "msbuild.exe" not found.
SUCCESS: The process with PID 6776 (child process of PID 2136) has been terminated.
SUCCESS: The process with PID 2136 (child process of PID 11140) has been terminated.
ERROR: The process "vctip.exe" not found.
ERROR: The process "h2spec.exe" not found.
ERROR: The process "WerFault.exe" not found.
ERROR: The process "chrome.exe" not found.
ERROR: The process "git.exe" not found.
build.cmd completed
##[error]Cmd.exe exited with code '1'.

My best guess is it was not caused by my changes . Maybe I should trigger the CI again?

/azp run

[newbienewbie]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 18311 in repo dotnet/aspnetcore