Skip to content

[release/3.1] Mark Blazor packages as nonshipping #18357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2020
Merged

[release/3.1] Mark Blazor packages as nonshipping #18357

merged 3 commits into from
Jan 15, 2020

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 15, 2020

We intended to mark these packages as non-shipping in 3.1.1, but the value set in Directory.Build.props was getting overwritten by the values in the individual projects. Local build confirms that these projects are now marked as nonshipping.

CC @mkArtakMSFT @danroth27 @dotnet/aspnet-build

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 15, 2020
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 15, 2020

@Pilchie am I correct that we can take this for 3.1.2 as a tell-mode infra change?

@Pilchie
Copy link
Member

Pilchie commented Jan 15, 2020

Yes please!

dougbu
dougbu approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: @wtgodbe and I chatted offline. Doing the Right Thing:tm: in the individual projects is much more clear.

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 15, 2020
@dougbu
Copy link
Contributor

dougbu commented Jan 15, 2020

Labeled as tell-mode per your comment @Pilchie

@wtgodbe wtgodbe changed the title Mark Blazor packages as nonshipping [release/3.1] Mark Blazor packages as nonshipping Jan 15, 2020
@wtgodbe wtgodbe added this to the 3.1.2 milestone Jan 15, 2020
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 15, 2020

Failures in the Windows test legs are in installing Chrome... could be transient. Will look after retry.

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 15, 2020

I also pinned our Blazor dependency in this branch, to indicate that we're not taking any more updates from that repo.

@wtgodbe wtgodbe merged commit 89d2640 into release/3.1 Jan 15, 2020
@wtgodbe wtgodbe deleted the wtgodbe/NonShippingBlazor branch January 15, 2020 20:11
@wtgodbe wtgodbe mentioned this pull request Jan 16, 2020
Merged
dougbu added a commit that referenced this pull request Jan 16, 2020
@dougbu
Revert "[release/3.1] Mark Blazor packages as nonshipping (#18357)"
33c7683 
This reverts commit 89d2640.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@mmitche mmitche mmitche approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@wtgodbe @Pilchie @dougbu @mmitche