Skip to content

Don't throw exception while flushing ReferenceReadStream #18548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2020
Merged

Don't throw exception while flushing ReferenceReadStream #18548

merged 1 commit into from
Jan 25, 2020

Conversation

MatyRi
Copy link
Contributor

@MatyRi MatyRi commented Jan 23, 2020

  • Removed throw in ReferenceReadStream.Flush()
  • Added noop override for ReferenceReadStream.FlushAsync()
  • Added unit tests for ReferenceReadStream

Addresses #18503

@ghost ghost added the area-servers label Jan 23, 2020
@dnfclas
Copy link

dnfclas commented Jan 23, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@MatyRi MatyRi marked this pull request as ready for review January 24, 2020 00:45
@Tratcher Tratcher merged commit 58a107b into dotnet:master Jan 25, 2020
@Tratcher
Copy link
Member

Thanks

@Tratcher Tratcher added this to the 5.0.0-preview1 milestone Jan 25, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@MatyRi @dnfclas @Tratcher @amcasey