Skip to content

React to dotnet/runtime SSL changes #18584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2020
Merged

React to dotnet/runtime SSL changes #18584

merged 2 commits into from
Jan 26, 2020

Conversation

BrennanConroy
Copy link
Member

These tests are getting an AuthenticationException on Fedora, Debian, and Ubuntu 18 (which run on internal CI only).

Is this expected behavior? Do we want to check for either IOException or AuthenticationException?

Likely caused by: dotnet/runtime#453
cc @wfurt

@jkotalik
Copy link
Contributor

It may be worth skipping these tests until we know precisely that either it's expected behavior or a regression.

Either way to move with dependency updates, let's merge this.

@Tratcher
Copy link
Member

File a tracking issue. Throwing a different (and inconsistent) exception is a regression.

@BrennanConroy BrennanConroy merged commit c180668 into master Jan 26, 2020
@BrennanConroy BrennanConroy deleted the brecon/exception branch January 26, 2020 05:15
@wfurt
Copy link
Member

wfurt commented Jan 27, 2020

I will take a look. This can be also outcome of work for dotnet/runtime#914. The general expectation is that if peer sends encrypted alert we would throw AuthenticationException. If peer closes the connection or if there is an incomplete frame we would throw IOException. In the past, we did not always handle alerts properly e.g. we failed to propagate them from the OS layer.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants