Fix nullref in ComponentsAnalyzer #18608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
approved these changes
Jan 28, 2020
| @@ -30,6 +30,9 @@ | |||
| --> | |||
| <IsStableBuild>false</IsStableBuild> | |||
| <IsStableBuild Condition=" '$(DotNetFinalVersionKind)' == 'release' ">true</IsStableBuild> | |||
|
|
|||
| <!-- Workaround issue with ComponentsAnalyzer throwing for interfaces --> | |||
| <DisableImplicitComponentsAnalyzers>true</DisableImplicitComponentsAnalyzers> | |||
There was a problem hiding this comment.
Could we file a follow up to undo this?
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| /*MMReturnType*/private Renderer GetRenderer() => _field; | ||
|
|
||
| public interface ITestInterface |
There was a problem hiding this comment.
FYI @rynowak \ @SteveSandersonMS \ @mkArtakMSFT :
type.BaseType for interface types is null: https://github.com/dotnet/aspnetcore/pull/18608/files#diff-f7300f2c3fe64cdbb8f5dfd7854b0b56R85. This causes the call to VisitDeclarationSymbol to null-ref. It looks like the compiler was swallowing this in the past, but they now are presented as warnings. We were able to author the unit test to trivially cause this to fail. Should we consider patching this?
BrennanConroy
added
the
analyzer
|
Yeah I would suggest patching this. Do we have a bug for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nullref was always there, but consuming a newer SDK/roslyn bits causes this to fail builds.