Try reenabling helix for components #18636

HaoK · 2020-01-28T21:00:34Z

No description provided.

HaoK · 2020-01-30T07:32:03Z

@MattGal looks like our "--" might have broken the attachment in the work items for failing tests to the download, it always goes to an empty tab for me now :(

I thought java JDK was already installed in the past, at least in the comments of https://github.com/dotnet/core-eng/issues/5302

I assumed it would already be on the path for the helix work items, but I'm seeing java not found (when trying to install things from npm/yarn)

Copying C:\Users\runner\AppData\Local\Temp\nodejs\node-v10.15.3-win-x64\* to .
Node.exe copied to .
C:\h\w\A5E808F7\w\AEE809F1\e\yarn -> C:\h\w\A5E808F7\w\AEE809F1\e\node_modules\yarn\bin\yarn.js
C:\h\w\A5E808F7\w\AEE809F1\e\yarnpkg -> C:\h\w\A5E808F7\w\AEE809F1\e\node_modules\yarn\bin\yarn.js
+ [email protected]
added 1 package in 0.594s
yarn install v1.21.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
$ selenium-standalone install
not found: java
Usage: selenium-standalone action [options]
error Command failed with exit code 255.

HaoK · 2020-01-31T17:16:56Z

@javiercn can you help me figure out how to get yarn working? Looks like its not a java on path issues since I manually downloaded and installed it, and yarn still fails to install selenium like so:

C:\h\w\989D0856\w\973D0894\e\yarnpkg -> C:\h\w\989D0856\w\973D0894\e\node_modules\yarn\bin\yarn.js
C:\h\w\989D0856\w\973D0894\e\yarn -> C:\h\w\989D0856\w\973D0894\e\node_modules\yarn\bin\yarn.js
+ [email protected]
added 1 package in 0.563s
yarn install v1.21.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
$ selenium-standalone install
not found: java
Usage: selenium-standalone action [options]
error Command failed with exit code 255.

"Java?"
Usage: java [options] <mainclass> [args...]
           (to execute a class)
   or  java [options] -jar <jarfile> [args...]
           (to execute a jar file)
   or  java [options] -m <module>[/<mainclass>] [args...]
       java [options] --module <module>[/<mainclass>] [args...]
           (to execute the main class in a module)
   or  java [options] <sourcefile> [args]
           (to execute a single source-file program)

javiercn · 2020-01-31T18:20:41Z

can you help me figure out how to get yarn working? Looks like its not a java on path issues since I manually downloaded and installed it, and yarn still fails to install selenium like so:

I'm a bit confused, isn't that exactly what the build is complaining about? If you do java -v in the context where the build is run, does it succeed?

HaoK · 2020-01-31T18:27:13Z

Oh i think I see the issue, the path isn't setup early enough

eng/targets/Helix.props

HaoK · 2020-02-01T09:03:23Z

@javiercn getting closer, where's this config file coming from for the selenium, need to change where its looking on helix

yarn install v1.21.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
$ selenium-standalone install --config ../../../Shared/E2ETesting/selenium-config.json
Error parsing config file : Cannot find module 'C:\h\w\AC56097A\Shared\E2ETesting\selenium-config.json'
Usage: selenium-standalone action [options]
error Command failed with exit code 255.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

HaoK · 2020-02-04T02:42:33Z

@pranavkm looks like https://github.com/dotnet/aspnetcore/pull/18676/files change is making this harder for components to run on helix since its now looking for a relative path, can we do something to make this look for that config file in the local directory (just copy it over as part of build or something?)

HaoK · 2020-02-04T18:21:17Z

@javiercn looks like the content root being generated at compile time is not going to work well on helix, can you look into a fix for this to work on helix, we control how the app is packaged and deployed so a relative path from the current directory should work I think?

aspnetcore/src/Components/test/testassets/TestServer/Components.TestServer.csproj

Line 28 in e72223e

    
           <_Parameter2>$([MSBuild]::NormalizeDirectory('$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)..\BasicTestApp'))'))</_Parameter2>

The error at runtime is a directory not found:

  Error Message:
   System.IO.DirectoryNotFoundException : F:\workspace\_work\1\s\src\Components\test\testassets\TestServer\
  Stack Trace:
     at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root, ExclusionFilters filters)
   at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root)
   at Microsoft.Extensions.Hosting.HostBuilder.CreateHostingEnvironment()
   at Microsoft.Extensions.Hosting.HostBuilder.Build()
   at TestServer.Program.BuildWebHost[TStartup](String[] args) in F:\workspace\_work\1\s\src\Components\test\testassets\TestServer\Program.cs:line 68
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.AspNetSiteServerFixture.CreateWebHost() in /_/src/Components/test/E2ETest/Infrastructure/ServerFixtures/AspNetSiteServerFixture.cs:line 37
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.WebHostServerFixture.StartAndGetRootUri() in /_/src/Components/test/E2ETest/Infrastructure/ServerFixtures/WebHostServerFixture.cs:line 17
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.ServerFixture.<.ctor>b__4_0() in /_/src/Components/test/E2ETest/Infrastructure/ServerFixtures/ServerFixture.cs:line 25

javiercn · 2020-02-04T19:12:55Z

@javiercn looks like the content root being generated at compile time is not going to work well on helix, can you look into a fix for this to work on helix, we control how the app is packaged and deployed so a relative path from the current directory should work I think?

I think so, you could key that of from IsHelixBuild?

HaoK · 2020-02-06T01:59:58Z

Okay finally some progress, @javiercn can you see if you can make out what's actually failing now?

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-18636-merge-76431147d907455ca6/Microsoft.AspNetCore.Components.E2ETests--netcoreapp5.0/console.99371bcb.log?sv=2019-02-02&se=2020-02-15T18%3A17%3A29Z&sr=c&sp=rl&sig=qB0WLFnBR4PsbOvMNGzwYWB3z8yad8QQm47i22BvTEo%3D

I'm seeing some errors around launching the server it looks like

javiercn · 2020-02-06T08:52:20Z

It seems is null refing here?

https://github.com/dotnet/aspnetcore/blob/master/src/Shared/E2ETesting/SeleniumStandaloneServer.cs#L202-L215

Not sure what can be causing it to fail there.

javiercn · 2020-02-06T08:53:15Z

@HaoK are the agents persistent or are they transient, in the sense they get re-imagined/rebooted per run.

We could try and remove the process tracking logic.

HaoK · 2020-02-06T09:10:42Z

@javiercn yeah i don't think we need process tracking logic at all on the helix agents, they shouldn't be getting reused

javiercn · 2020-02-06T09:11:29Z

@javiercn yeah i don't think we need process tracking logic at all on the helix agents, they shouldn't be getting reused

I suggest we disable it then

HaoK · 2020-02-06T09:12:46Z

Sounds good to me, can you just push onto this branch the removal of the process tracking stuff that you don't think we need?

javiercn · 2020-02-06T09:13:37Z

@HaoK Is there a Helix env variable I can key this off?

HaoK · 2020-02-06T09:14:55Z

Yeah just use

 if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("helix")))

HaoK · 2020-02-19T00:21:34Z

branch looks messed up with builds not triggering, doing a merge/force push here @javiercn , just a heads up in case you have changes locally

HaoK · 2020-02-19T04:26:39Z

Progress I think, tests are still failing but not due to selenium, console output is here @javiercn :

https://helix.dot.net/api/2019-06-17/jobs/d42b348b-03ce-4a9c-88f6-086fa01d7fcb/workitems/Microsoft.AspNetCore.Components.E2ETests--netcoreapp5.0/files/console.e25e0e27.log

MattGal · 2020-03-11T16:14:39Z

@HaoK I'm unsubscribing from this thread as it's a bit noisy, but if you need my input on anything just let me know directly please.

HaoK · 2020-03-11T22:12:51Z

@javiercn @pranavkm so it looks like installing yarn nukes npm, which then causes issues when selenium runs, any ideas how these two are supposedly to play together, what should the steps be on the helix side for things to be installed correctly? Right now I just tried using npm to install yarn, and then running yarn install, which looks like it works, but when the tests run selenium blows up because npm's cli gets nuked by yarn I think

pranavkm · 2020-03-11T22:23:31Z

@HaoK, you should be able to switch the test runner to use yarn instead of npm. Basically replace npm -> yarn here:

HaoK · 2020-03-12T21:02:00Z

@pranavkm so looks like both yarn and npm are missing from node_modules after yarn install,

https://helix.dot.net/api/2019-06-17/jobs/877f305e-496c-4aea-a656-aec446c4ac16/workitems/Microsoft.AspNetCore.Components.E2ETests--netcoreapp5.0/files/console.37ab6af8.log

Any idea what nukes those?

HaoK · 2020-03-14T20:30:48Z

Okay I think I got selenium working now, but the tests appear to be hanging, @pranavkm @javiercn can you guys tell what's going on from the exceptions, the screenshots are taken but its hanging so they don't get uploaded I think, I can try having the test directly write to the upload directory

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-18636-merge-6b03aadab2d64a749c/Microsoft.AspNetCore.Components.E2ETests--netcoreapp5.0/console.c865d749.log?sv=2019-02-02&se=2020-03-24T09%3A01%3A48Z&sr=c&sp=rl&sig=zt9RkAPid99FI6EIiNycGKQ6w5AJhHOCNCgYlbia3rk%3D

HaoK · 2020-04-28T19:11:14Z

Replaced by #21280

HaoK mentioned this pull request Jan 28, 2020

Reenable component E2E tests on helix #10997

Closed

HaoK added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 28, 2020

BrennanConroy reviewed Feb 1, 2020

View reviewed changes

eng/targets/Helix.props Outdated Show resolved Hide resolved

HaoK force-pushed the haok/helix-comp branch from 2643e80 to 29b0419 Compare February 4, 2020 06:40

HaoK mentioned this pull request Feb 11, 2020

Add support for running helix tests against built shared fx #16828

Closed

HaoK force-pushed the haok/helix-comp branch from d4f6d37 to 7b6d835 Compare February 19, 2020 00:21

BrennanConroy mentioned this pull request Feb 25, 2020

Add scheduled quarantine runs #19352

Merged

HaoK added 5 commits March 9, 2020 11:50

Try reenabling helix for components

b134013

Update Microsoft.AspNetCore.Components.E2ETests.csproj

8e7a6fc

Update Microsoft.AspNetCore.Components.E2ETests.csproj

90aa6ba

Update Microsoft.AspNetCore.Components.E2ETests.csproj

7408c37

Update Microsoft.AspNetCore.Components.E2ETests.csproj

8f2d148

HaoK added 2 commits March 10, 2020 21:47

Update InstallYarn.cmd

705f094

Update InstallYarn.cmd

f0b613b

HaoK added 5 commits March 11, 2020 15:35

npm => yarn

251a6ab

Update InstallYarn.cmd

1a889f2

Update SeleniumStandaloneServer.cs

938b064

Update SeleniumStandaloneServer.cs

d1519c7

Update SeleniumStandaloneServer.cs

6b729c9

HaoK added 13 commits March 13, 2020 00:03

Update InstallYarn.cmd

cd3b9e6

Manually restore npm/yarn

474270d

Fix config path

97c6501

InstallChrome

bde697d

Update Helix.targets

0e36a95

Update Microsoft.AspNetCore.Components.E2ETests.csproj

ecc7884

Update Microsoft.AspNetCore.Components.E2ETests.csproj

f8923ac

Fix screenshot path

d4c53d8

Copy logs and screenshots to upload root

17eaf65

Remove spew

3dcea8c

Update Microsoft.AspNetCore.Components.E2ETests.csproj

9e996fa

Update E2ETestOptions.cs

4887b70

Fix upload

5762d66

Try writing screenshots to upload root

51a9029

HaoK mentioned this pull request Apr 28, 2020

Enable components tests on helix #21280

Closed

HaoK closed this Apr 28, 2020

HaoK deleted the haok/helix-comp branch May 18, 2020 23:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try reenabling helix for components #18636

Try reenabling helix for components #18636

HaoK commented Jan 28, 2020

HaoK commented Jan 30, 2020

HaoK commented Jan 31, 2020

javiercn commented Jan 31, 2020

HaoK commented Jan 31, 2020

HaoK commented Feb 1, 2020

HaoK commented Feb 4, 2020

HaoK commented Feb 4, 2020

javiercn commented Feb 4, 2020

HaoK commented Feb 6, 2020

javiercn commented Feb 6, 2020

javiercn commented Feb 6, 2020

HaoK commented Feb 6, 2020

javiercn commented Feb 6, 2020

HaoK commented Feb 6, 2020

javiercn commented Feb 6, 2020

HaoK commented Feb 6, 2020

HaoK commented Feb 19, 2020

HaoK commented Feb 19, 2020 •

edited

Loading

MattGal commented Mar 11, 2020

HaoK commented Mar 11, 2020

pranavkm commented Mar 11, 2020

HaoK commented Mar 12, 2020

HaoK commented Mar 14, 2020

HaoK commented Apr 28, 2020

Try reenabling helix for components #18636

Try reenabling helix for components #18636

Conversation

HaoK commented Jan 28, 2020

HaoK commented Jan 30, 2020

HaoK commented Jan 31, 2020

javiercn commented Jan 31, 2020

HaoK commented Jan 31, 2020

HaoK commented Feb 1, 2020

HaoK commented Feb 4, 2020

HaoK commented Feb 4, 2020

javiercn commented Feb 4, 2020

HaoK commented Feb 6, 2020

javiercn commented Feb 6, 2020

javiercn commented Feb 6, 2020

HaoK commented Feb 6, 2020

javiercn commented Feb 6, 2020

HaoK commented Feb 6, 2020

javiercn commented Feb 6, 2020

HaoK commented Feb 6, 2020

HaoK commented Feb 19, 2020

HaoK commented Feb 19, 2020 • edited Loading

MattGal commented Mar 11, 2020

HaoK commented Mar 11, 2020

pranavkm commented Mar 11, 2020

HaoK commented Mar 12, 2020

HaoK commented Mar 14, 2020

HaoK commented Apr 28, 2020

HaoK commented Feb 19, 2020 •

edited

Loading