Skip to content

[release/3.1] Update dependencies from EFCore #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 20, 2020

After Extensions removed the Mono.WebAssembly.Interop package yesterday, Maestro silently failed to update our dependencies from EFCore, because we still listed a dependency on that package despite it not being produced (thanks @riarenas for helping figure this out). I deleted that package from our version files & ran darc update-dependencies locally. Here's the issue tracking making these types of failures less difficult to notice/track down: dotnet/arcade#1387

CC @dougbu @JunTaoLuo - after this I can validate #19161 (since this updates System.IO.Pipelines to 4.7.1)

@wtgodbe wtgodbe requested a review from dougbu as a code owner February 20, 2020 17:02
@wtgodbe wtgodbe changed the title Wtgodbe/ef deps [release/3.1] Update dependencies from EFCore Feb 20, 2020
@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 20, 2020

/Users/runner/runners/2.164.8/work/1/s/src/Components/Blazor/testassets/HostedInAspNet.Server/HostedInAspNet.Server.csproj : warning NU1602: Microsoft.AspNetCore.Blazor does not provide an inclusive lower bound for dependency Mono.WebAssembly.Interop. An approximate best match of Mono.WebAssembly.Interop 0.5.0 was resolved.

Services/WebAssemblyJSRuntime.cs(9,50): error CS0012: The type 'JSInProcessRuntimeBase' is defined in an assembly that is not referenced. You must add a reference to assembly 'Microsoft.JSInterop, Version=0.5.0.0, Culture=neutral, PublicKeyToken=null'. [/Users/runner/runners/2.164.8/work/1/s/src/Components/Blazor/Blazor/src/Microsoft.AspNetCore.Blazor.csproj]

@pranavkm should I instead have pinned the dependency on Mono.WebAssembly.Interop?

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 20, 2020

We still use Mono.WebAssembly.Interop, so I put it in the manual section of versions.props (effectively pinning it): https://github.com/dotnet/aspnetcore/pull/19201/files#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR207

@wtgodbe wtgodbe merged commit e7e9a2c into release/3.1 Feb 20, 2020
@wtgodbe wtgodbe deleted the wtgodbe/EFDeps branch February 20, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants