Skip to content

Suppress ClientHandshakeFailureLoggedAsDebug for 5.0.0-preview1 #19294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Tratcher
Copy link
Member

This test was broken by a recent dependency update. It was fixed in master, but we've opted to skip it in preview1 to unblock builds rather than spend time backporting the fix.

Fixes: https://dev.azure.com/dnceng/internal/_build/results?buildId=533310&view=ms.vss-test-web.build-test-results-tab&runId=16959222&resultId=106133&paneView=debug

@Tratcher Tratcher self-assigned this Feb 24, 2020
@ghost ghost added the area-servers label Feb 24, 2020
@Tratcher Tratcher added this to the 5.0.0-preview1 milestone Feb 24, 2020
@analogrelay
Copy link
Contributor

FYI @mmitche @wtgodbe this is skipping a test in Preview 1 to unblock the build. On your approval (to confirm branches are clear to merge) I can merge ASAP.

@mmitche
Copy link
Member

mmitche commented Feb 24, 2020

Go for merge!

@mmitche mmitche merged commit 98a853b into release/5.0-preview1 Feb 24, 2020
@mmitche mmitche deleted the tratcher/release/5.0-preview1/suppress branch February 24, 2020 19:04
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants