Reenable framework unit tests on helix #19975

HaoK · 2020-03-18T21:38:40Z

No description provided.

HaoK · 2020-03-20T23:12:20Z

@dougbu @dotnet/aspnet-build does anyone know where the .version file in the sharedruntime comes from? I see a .version file in the official versions that are installed on my machine, but when I look at what we build in artifacts, i.e. Windows_Packages/Release/Shipping/Microsoft.AspNetCore.App.Runtime.win-x64-50.0.0-ci.nupg I don't see a .versions file in there, which the framework unit tests seem to be expecting.

dougbu · 2020-03-20T23:18:27Z

does anyone know where the .version file in the sharedruntime comes from?

aspnetcore/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj

Lines 254 to 270 in ce0886c

    
           <Target Name="GenerateSharedFxVersionsFiles" DependsOnTargets="InitializeSourceControlInformation"> 
        
             <WriteLinesToFile 
        
               File="$(BaseRuntimeVersionFileOutputPath)" 
        
               Lines="$(MicrosoftNETCoreAppRuntimeVersion)" 
        
               Overwrite="true" /> 
        
             <!-- Generates the .version file in the shared framework --> 
        
             <ItemGroup> 
        
               <VersionLines Include="$(SourceRevisionId)" /> 
        
               <VersionLines Include="$(SharedFxVersion)" /> 
        
             </ItemGroup> 
        
             <WriteLinesToFile 
        
               File="$(VersionFileIntermediateOutputPath)" 
        
               Lines="@(VersionLines)" 
        
               Overwrite="true" /> 
        
           </Target>

And that target should run unconditionally.

HaoK · 2020-03-20T23:24:42Z

@dougbu does that mean it should be in the app runtime nupkgs of our artifacts? https://dev.azure.com/dnceng/public/_build/results?buildId=567706&view=artifacts&type=publishedArtifacts

dougbu · 2020-03-20T23:37:14Z

does that mean it should be in the app runtime nupkgs of our artifacts?

Yes. I'm not sure why Microsoft.AspNetCore.App.Runtime.linux-arm.5.0.0-ci.nupkg and 5.0.0-preview.3.20170.3 (from an official build and in the netcore5 feed) don't include the file. Maybe it's not supposed to ship?

@wtgodbe and @JunTaoLuo shouldn't there be a .versions file in our runtime packages? Or, is that one of the outstanding issues on the Build plate?

wtgodbe · 2020-03-20T23:58:34Z

Looks like there's no ThirdPartyNotices.txt file in there either - something isn't working right in that project, I'm guessing. I can take a look on Monday

HaoK · 2020-03-21T01:13:34Z

Well I guess this is actually an argument in favor of running these framework tests on helix (which runs against the shared framework built artifacts) since the versions file does exist in today's runs of these tests...so there's a difference somewhere...?

HaoK · 2020-03-23T22:26:31Z

Marking as ready for review, I've skipped the failing .versions file for now and filed #20086 to track resolving that. I left the tests running on both azdo and helix for now until we are able to resolve the .Versions check

dougbu

I suspect we need to do more to prepare for servicing. But, I defer to @JunTaoLuo on whether this migration will make such work more difficult. @JunTaoLuo please review.

eng/targets/Helix.targets

wtgodbe · 2020-03-27T17:30:38Z

@HaoK after https://github.com/dotnet/aspnetcore/pull/20250/files you should be able to un-disable ItContainsVersionFile

HaoK · 2020-03-27T17:33:35Z

Awesome thanks @wtgodbe!

@JunTaoLuo are you ok with these tests being enabled as they are for now? Do you want me to file an issue for any servicing concerns about these tests so you can revisit this in the future?

Update Microsoft.AspNetCore.App.UnitTests.csproj Update TargetingPackTests.cs Update SharedFxTests.cs Update TargetingPackTests.cs Update InstallAspNetRef.ps1 Update Helix.targets Create installaspnetref.sh Update SharedFxTests.cs Update TargetingPackTests.cs Update SharedFxTests.cs Fix runtimeVersion Update runtests.cmd Update runtests.cmd Update runtests.sh Update runtests.sh Update runtests.cmd Update SharedFxTests.cs Update runtests.cmd Update runtests.cmd Update InstallAppRuntime.ps1 Update runtests.sh Skip versions file check on helix for now Update Microsoft.AspNetCore.App.UnitTests.csproj Run unit tests on azdo too Update SharedFxTests.cs Update SharedFxTests.cs Update Microsoft.AspNetCore.App.UnitTests.csproj

HaoK · 2020-04-07T04:16:06Z

Ok finally the framework tests are all green again, @dougbu @JunTaoLuo can you take a final look

JunTaoLuo

One nit

BrennanConroy · 2020-04-07T20:33:35Z

eng/helix/content/installaspnetref.sh

@@ -0,0 +1,15 @@
+#!/usr/bin/env bash


Can we migrate these to C#

Yeah i'll file an issue for this and the other one (shared runtime)

This reverts commit 9a792f2.

ghost added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Mar 18, 2020

HaoK mentioned this pull request Mar 23, 2020

Missing .versions file & Third-Party-Notices.txt in shared fx #20086

Closed

HaoK marked this pull request as ready for review March 23, 2020 22:26

HaoK requested a review from a team March 23, 2020 22:26

HaoK changed the title ~~See if framework tests work now~~ Reenable framework unit tests on helix Mar 23, 2020

This was referenced Mar 23, 2020

Flaky test RequestHeaders_MultipleFrames_Accepted #20087

Closed

Flaky test FlowControl_ParallelStreams_FirstInFirstOutOrder #20088

Closed

Flaky test ProcessAsync_AwaitersUseTheResultOfExecutor #20089

Closed

dougbu reviewed Mar 23, 2020

View reviewed changes

eng/targets/Helix.targets Show resolved Hide resolved

HaoK force-pushed the haok/helix-fxtests branch 2 times, most recently from bb131ac to a2c7182 Compare April 3, 2020 08:53

HaoK added 10 commits April 6, 2020 02:08

See if framework tests work now

8b2bd91

Fix sharedfx root for helix runs

aac0214

Look for targeting pack in right place

dc1a955

Add TestDependsOnAspnetRef logic

34802dc

Install ref package

9b50e8f

Update SharedFxTests.cs

3b7fa9a

Set ASPNET_RUNTIME_PATH for helix

2441b7a

Update TestRunner.cs

487b468

Update TestRunner.cs

7514a3a

HaoK added 3 commits April 6, 2020 02:08

Update TestRunner.cs

1ace386

Update ci.yml

9f448ea

Update ci.yml

26e1bd0

HaoK force-pushed the haok/helix-fxtests branch from a4b4f5e to 26e1bd0 Compare April 6, 2020 09:08

HaoK added 5 commits April 6, 2020 11:04

Dump shared app directory contents

332b811

Also copy root txt files from shared fx

1e87c08

Update installappruntime.sh

7db26af

Update Microsoft.AspNetCore.App.UnitTests.csproj

bc6c0f7

Update SharedFxTests.cs

065a936

JunTaoLuo approved these changes Apr 7, 2020

View reviewed changes

BrennanConroy reviewed Apr 7, 2020

View reviewed changes

Don't try to copy ref pack if its not building

1914679

dougbu approved these changes Apr 8, 2020

View reviewed changes

HaoK merged commit 9a792f2 into master Apr 8, 2020

HaoK deleted the haok/helix-fxtests branch April 8, 2020 06:39

HaoK mentioned this pull request Apr 8, 2020

[Helix] enable framework unit tests #7939

Closed

HaoK added a commit that referenced this pull request Apr 8, 2020

Revert "Reenable framework unit tests on helix (#19975)"

b3aee8c

This reverts commit 9a792f2.

ghost pushed a commit that referenced this pull request Apr 9, 2020

Revert "Reenable framework unit tests on helix (#19975)" (#20657)

1bbca15

This reverts commit 9a792f2.

Reenable framework unit tests on helix #19975

Reenable framework unit tests on helix #19975

Uh oh!

Conversation

HaoK commented Mar 18, 2020

Uh oh!

HaoK commented Mar 20, 2020

Uh oh!

dougbu commented Mar 20, 2020

Uh oh!

HaoK commented Mar 20, 2020

Uh oh!

dougbu commented Mar 20, 2020

Uh oh!

wtgodbe commented Mar 20, 2020

Uh oh!

HaoK commented Mar 21, 2020

Uh oh!

HaoK commented Mar 23, 2020

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wtgodbe commented Mar 27, 2020

Uh oh!

HaoK commented Mar 27, 2020

Uh oh!

HaoK commented Apr 7, 2020

Uh oh!

JunTaoLuo left a comment

Choose a reason for hiding this comment

Uh oh!

BrennanConroy Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

HaoK Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

HaoK Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!