Skip to content

Fix memory leak in HubConnection #20099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nymitr
Copy link
Contributor

@nymitr nymitr commented Mar 24, 2020

This fixes memory leak in java client HubConnection.

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Mar 24, 2020
@analogrelay analogrelay added this to the 5.0.0-preview3 milestone Mar 24, 2020
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good. I have this in a larger change around closing things properly. But haven't prepared a PR yet.

@BrennanConroy BrennanConroy merged commit 196f448 into dotnet:master Mar 24, 2020
@analogrelay
Copy link
Contributor

Thanks for the contribution @nymitr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants