Skip to content

Diagnose more gRPC template hangs #20206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

Conversation

JunTaoLuo
Copy link
Contributor

The symptoms under diagnosis:

[0.028s] [TestLifetime] [Information] Starting test GrpcTemplate at 2020-03-26T04:44:10
[9,535.658s] [TestLogger] [Information] AspNetProcess - process: /Users/runner/runners/2.165.2/work/1/s/.dotnet/dotnet arguments: exec /Users/runner/runners/2.165.2/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp5.0/TestTemplates/AspNet.grpc.mnuhnsvae3x/bin/Debug/netcoreapp5.0/AspNet.grpc.mnuhnsvae3x.dll
[9,535.669s] [TestLogger] [Information] AspNetProcess - process started

This could be an issue in our test setup (creating, publishing and building the SUT) or it could be an issue with the project template infrastructure (uninstalling/installing the project template via dotnet new --install).

@JunTaoLuo JunTaoLuo force-pushed the johluo/more-grpc-hangs branch from 3bf657f to 766a91d Compare March 26, 2020 20:49
@JunTaoLuo JunTaoLuo force-pushed the johluo/more-grpc-hangs branch from f4a1c7c to 0bf7976 Compare March 27, 2020 17:07
@Pilchie Pilchie added the area-grpc Includes: GRPC wire-up, templates label Mar 27, 2020
@JunTaoLuo
Copy link
Contributor Author

[0.054s] [TestLifetime] [Information] Starting test GrpcTemplate at 2020-03-29T19:30:10
[0.054s] [TestLogger] [Information] GrpcTemplateTest - Test start
[18.267s] [TestLogger] [Information] GrpcTemplateTest - Initialize project
[57.831s] [TestLogger] [Information] GrpcTemplateTest - Created project
[95.133s] [TestLogger] [Information] GrpcTemplateTest - published project
[134.298s] [TestLogger] [Information] GrpcTemplateTest - built project
[134.299s] [TestLogger] [Information] GrpcTemplateTest - Starting built project
[134.303s] [TestLogger] [Information] Project - creating AspNetProcess
[134.305s] [TestLogger] [Information] AspNetProcess - initializing
[134.312s] [TestLogger] [Information] AspNetProcess - http client created
[134.312s] [TestLogger] [Information] AspNetProcess/EnsureDevelopmentCertificates - start
[9,573.174s] [TestLogger] [Information] AspNetProcess/EnsureDevelopmentCertificates - end
[9,573.174s] [TestLogger] [Information] AspNetProcess - development certificates resolved
[9,573.174s] [TestLogger] [Information] AspNetProcess - process: /Users/runner/runners/2.165.2/work/1/s/.dotnet/dotnet arguments: exec /Users/runner/runners/2.165.2/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp5.0/TestTemplates/AspNet.grpc.nsi20enodmc/bin/Debug/netcoreapp5.0/AspNet.grpc.nsi20enodmc.dll
[9,573.179s] [TestLogger] [Information] AspNetProcess - process started
[9,573.179s] [TestLogger] [Information] GrpcTemplateTest - Verifing built project results
[9,574.049s] [TestLogger] [Information] GrpcTemplateTest - Verifing published project results
[9,574.726s] [TestLifetime] [Information] Finished test GrpcTemplate in 9575.1650592s

This pretty much conclusively proves that the hang is within https://github.com/dotnet/aspnetcore/blob/master/src/Shared/CertificateGeneration/CertificateManager.cs#L727.

Who would be knowledgeable in this area? @mkArtakMSFT @anurse @javiercn. Not sure if it's relevant but we recently changed the macOS agent from 10.13 to 10.14.

@analogrelay
Copy link
Contributor

@javiercn is probably the one who's made changes there.

@JunTaoLuo
Copy link
Contributor Author

@javiercn thinks he fixed the hangs with #20494. We'll turn the tests back on.

@JunTaoLuo JunTaoLuo closed this Apr 3, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/more-grpc-hangs branch May 22, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants