Remove workaround in HeaderPropagationMiddleware #20533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed by #14146 which starts each request on a fresh ExecutionContext
ghost
added
the
halter73
commented
Apr 4, 2020
| @@ -185,43 +185,5 @@ public async Task MultipleEntries_AddsFirstToProduceValue() | |||
| Assert.Contains("in", CapturedHeaders.Keys); | |||
| Assert.Equal("Test", CapturedHeaders["in"]); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task HeaderInRequest_WithBleedAsyncLocal_HasCorrectValue() | |||
There was a problem hiding this comment.
I removed these tests because it's the responsibility of the server, not the middleware, to ensure it has a fresh ExecutionContext for each request. The HeaderPropagationMiddleware does not have any functional tests, and @benaadams already added functional tests to verify IAsyncLocals in general work as expected with Kestrel.
That said, I did manually verify that #14146 fixes things so that the HeaderPropagationMiddleware sees a fresh HeaderPropagationValues each request after removing async from Invoke. And verified this was not the case without the changes from #14146.
davidfowl
approved these changes
Apr 5, 2020
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by #14146 which starts each request on a fresh ExecutionContext