Enable FxCop Analyzers for the repo #23709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
reviewed
Jul 6, 2020
dougbu
approved these changes
Jul 6, 2020
All rules are currently disabled, except for one that I enabled for src/Http via a new ".editorconfig" file I added there. Other changes: * Allow editorconfigs in MVC and Razor to flow to the root * Consolidate a few editorconfig settings * Tweak Ruleset config in Azure/AzureAD where it clashed. Addresses the beginning of dotnet#9620, but it's a fair chunk of work to enable most rules through the whole repo. That can be done directory by directory and rule by rule by dropping .editorconfig files though.
|
@javiercn - I'll leave this in case anyone wants to discuss in the @dotnet/aspdoi meeting tomorrow (though I won't be there). |
|
LGTM, I'll make sure we discuss it on Today's meeting, but it sounds reasonable to me. This is a good starting point and we can work on adding rules on a per-case basis as we deem fit. |
|
We didn't get time to discuss this in today's meeting, but I think we can go ahead with these changes and start looking at individual rules. |
javiercn
approved these changes
Jul 7, 2020
mkArtakMSFT
added
the
area-infrastructure
wtgodbe
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All rules are currently disabled, except for one that I enabled for
src/Http via a new ".editorconfig" file I added there.
Other changes:
Addresses the beginning of #9620, but it's a fair chunk of work to
enable most rules through the whole repo. That can be done directory by
directory and rule by rule by dropping .editorconfig files though.