Skip to content

[IIS] Move to GenericHost #24280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2020
Merged

[IIS] Move to GenericHost #24280

merged 5 commits into from
Jul 28, 2020

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Jul 24, 2020

Part of #20964

@ghost ghost added the area-servers label Jul 24, 2020
@Tratcher Tratcher requested a review from BrennanConroy July 24, 2020 16:24
@jkotalik
Copy link
Contributor

Looks like a lot of tests are failing in the IISIntegration middleware tests, for example MiddlewareShutsdownGivenANCMShutdown. Can you look into why those are failing?

@Tratcher
Copy link
Member

Test failures:
https://dev.azure.com/dnceng/public/_build/results?buildId=744553&view=ms.vss-test-web.build-test-results-tab&runId=23076178&resultId=102339&paneView=debug

It's missing a call to StartAsync()

@Tratcher
Copy link
Member

A few test failures.
https://dev.azure.com/dnceng/public/_build/results?buildId=744859&view=ms.vss-test-web.build-test-results-tab&runId=23085538&paneView=debug

@BrennanConroy BrennanConroy merged commit 0859213 into dotnet:master Jul 28, 2020
@BrennanConroy
Copy link
Member

Thanks!

@BrennanConroy BrennanConroy mentioned this pull request Jul 28, 2020
Open
@Kahbazi Kahbazi deleted the kahbazi/IISHostBuilder branch July 28, 2020 18:29
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kahbazi @jkotalik @Tratcher @BrennanConroy @amcasey