Skip to content

Rename KeepAlivePingInterval to KeepAlivePingDelay #24308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 25, 2020

SocketsHttpHandler is adding KeepAlivePingDelay property. Our setting is called KeepAlivePingInterval.

dotnet/runtime#31198 (comment)

I think both names are fine. For consistency let rename Kestrel's property to match.

@JamesNK JamesNK force-pushed the jamesnk/keepaliveping-delay branch from 2ccbf9d to a96a7d4 Compare July 25, 2020 02:11
@JamesNK JamesNK requested review from a team and removed request for a team and SteveSandersonMS July 25, 2020 02:11
@davidfowl
Copy link
Member

So we expose any other intervals?

@JamesNK JamesNK removed the request for review from a team July 25, 2020 02:23
@JamesNK
Copy link
Member Author

JamesNK commented Jul 25, 2020

Everywhere we expose TimeSpan properties on KestrelServerOptions/KestrelServerLimits/Http2Limits the property name ends with Timeout.

@JamesNK JamesNK added the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Jul 26, 2020
@ghost
Copy link

ghost commented Jul 26, 2020

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@JamesNK JamesNK added this to the 5.0.0-rc1 milestone Jul 27, 2020
@pranavkm pranavkm added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews labels Jul 28, 2020
@JamesNK JamesNK merged commit 2243f3f into master Jul 28, 2020
@JamesNK JamesNK deleted the jamesnk/keepaliveping-delay branch July 28, 2020 00:32
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-approved API was approved in API review, it can be implemented area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants