Skip to content

Add tests for navigate on form submit #24684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2020
Merged

Add tests for navigate on form submit #24684

merged 4 commits into from
Aug 12, 2020

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Aug 7, 2020 •
edited
Loading

Closes #21241.

I wasn't able to repro the issue on master so it looks like something we've done between now and then has resolved the issue.

Adding a test for this bug so we have coverage for it.

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 7, 2020
@captainsafia captainsafia marked this pull request as ready for review August 9, 2020 18:38
@captainsafia captainsafia requested review from SteveSandersonMS and a team as code owners August 9, 2020 18:38
@captainsafia captainsafia added this to the 5.0.0-rc1 milestone Aug 9, 2020
@SteveSandersonMS
Copy link
Member

I was a bit thrown off by this because I didn't think we'd changed anything that would be likely to affect this. Upon verifying, this does still repro for me on master. Is it possible that it doesn't repro within the E2E project because it doesn't have a top-level <Router>, and hence it's trying to do server-side navigation?

For clarification here's what reproduces the issue for me: https://github.com/dotnet/aspnetcore/compare/stevesa/blur-bug-repro. Apologies for the ambiguity/typos in the original bug report.

@captainsafia
Copy link
Member Author

I was a bit thrown off by this because I didn't think we'd changed anything that would be likely to affect this. Upon verifying, this does still repro for me on master. Is it possible that it doesn't repro within the E2E project because it doesn't have a top-level , and hence it's trying to do server-side navigation?

Hm. I'll check on this. I validated inside the test harness and in a new standalone WASM project using 5.0-dev bits. I'll give your repro ago in case I missed something.

@captainsafia
Copy link
Member Author

@SteveSandersonMS Woop. You're right. I'm able to repro this on a standalone app with the 5.0.100-rc.1.20405.4 SDK so it's definitely still an issue. I'll investigate and push a fix to this PR.

@captainsafia captainsafia force-pushed the safia/blur-validation branch 3 times, most recently from ba0d09e to b970b99 Compare August 11, 2020 20:50
@captainsafia captainsafia force-pushed the safia/blur-validation branch 2 times, most recently from 1932658 to 220da3a Compare August 12, 2020 02:53
@captainsafia captainsafia force-pushed the safia/blur-validation branch from 220da3a to 26e7f26 Compare August 12, 2020 15:36
SteveSandersonMS
SteveSandersonMS approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@captainsafia captainsafia merged commit 577f1a7 into master Aug 12, 2020
@captainsafia captainsafia deleted the safia/blur-validation branch August 12, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@campersau campersau campersau left review comments

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.

Blur event inside form can cause "no event handler associated with this event" exception
3 participants
@captainsafia @SteveSandersonMS @campersau