Fix HTTP/2 tests that use HttpClient and H2C #24981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Aug 17, 2020
|
|
||
| protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) | ||
| { | ||
| request.VersionPolicy = HttpVersionPolicy.RequestVersionOrHigher; |
There was a problem hiding this comment.
You plan on using Exact in gRPC, no?
Suggested change
| request.VersionPolicy = HttpVersionPolicy.RequestVersionOrHigher; | |
| request.VersionPolicy = HttpVersionPolicy.RequestVersionExact; |
There was a problem hiding this comment.
Theoretically gRPC should work with HTTP/3 so OrHigher seems like the best choice.
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Outdated
Show resolved
Hide resolved
dougbu
reviewed
Aug 18, 2020
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Show resolved
Hide resolved
JamesNK
added
the
tell-mode
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24902