-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Add build for linux-musl-arm #26281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build for linux-musl-arm #26281
Conversation
This change adds support for building MUSL ARM packages of ASP.NET Core.
We want to enable end to end .NET Core support for Alpine ARM Linux. It has been requested by the community for quite some time. I have discussed it with @richlander and we have agreed that we should do it if it doesn't require too much work to enable. So far we had only Alpine ARM64 support. So far I've created the necessary docker images and made runtime changes, so this is a next step.
It would be nice, but it is not a hard requirement.
No, can you please help me understand what is it good for? I can see that it uses ubuntu-16.04 VM and I know the build doesn't build there due to the fact that the cross building image for runtime is based on Ubuntu 18.04, so crossgen fails to execute. Is that a problem? If it is, I can add cross building ubuntu-16.04 docker images targeting Alpine ARM and switch runtime to build on that one. |
That setting is useful where the build uses more disk space than hosted agents provide. But, ignore me because the Linux MUSL Arm64 probably has it for a reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine w/ me. Any objection @Pilchie❔
Seems fine to me. |
@dougbu, @Pilchie I've incorrectly assumed that the change will automatically flow into release/5.0, since I've seen 5.0-rc2 packages generated after my change went in. But looking at the release/5.0 branch, I cannot see my commit to be there. |
@janvorli this isn't really "just an infra change" because it expands the platform. Why would we port it to the release/5.0 branch given your earlier comment about needing the change to 5.0❔
|
@dougbu - since I've seen 5.0-rc2 nuget packages were available on the nuget servers for linux-musl-arm after my change, I've assumed that it somehow made it to 5.0 and we've back ported the related runtime change to 5.0. Now there was an attempt to build docker image for linux-musl-arm, which revealed that the aspnetcore tarball doesn't actually exist. |
@Pilchie do you think we need this in 5.0.1❔ |
I think it's fine to add for 5.0.1, but I don't understand how there were packages for rc2 and not GA. The commit above looks like it was only ever in |
/backport to release/5.0 |
This change adds building of linux-musl-arm packages of ASP.NET Core.