Add doc strings for public APIs in Http.Abstractions and Routing.Abstractions #26468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
JamesNK
reviewed
Sep 30, 2020
src/Http/Http.Abstractions/src/Extensions/ResponseTrailerExtensions.cs
Outdated
Show resolved
Hide resolved
captainsafia
force-pushed
the
safia/http-abstract-docs
branch
from
1491840 to
4e8f212
Compare
Co-authored-by: James Newton-King <[email protected]>
pranavkm
approved these changes
Sep 30, 2020
| @@ -8,23 +8,45 @@ | |||
|
|
|||
| namespace Microsoft.AspNetCore.Http | |||
| { | |||
| /// <summary> | |||
There was a problem hiding this comment.
Shoot: #26358. I had some of these documented in an earlier pass. I should have clarified it in the docs
| public static class StatusCodes | ||
| { | ||
| /// <summary> | ||
| /// HTTP status code 100. | ||
| /// </summary> | ||
| public const int Status100Continue = 100; |
There was a problem hiding this comment.
Good grief. I gave up when I got to this type
There was a problem hiding this comment.
A little patience and a whole lotta Cmd+V 😝 .
| @@ -13,7 +16,7 @@ public class LinkOptions | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets a value indicating whether a generated query strings are lowercase. | |||
| /// This property will be unless <see cref="LowercaseUrls" /> is also <c>true</c>. | |||
| /// This property will be false unless <see cref="LowercaseUrls" /> is also <c>true</c>. | |||
ajaybhargavb
added
the
tell-mode
Tratcher
reviewed
Oct 1, 2020
| @@ -3,77 +3,338 @@ | |||
|
|
|||
| namespace Microsoft.AspNetCore.Http | |||
| { | |||
| // Status Codes listed at http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml | |||
| /// <summary> | |||
| /// A collection of contants for HTTP status codes. | |||
There was a problem hiding this comment.
Oof. I'll fix this in my other PR.
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26397.