Add more mvc/view features API docs #26615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
captainsafia
reviewed
Oct 6, 2020
There was a problem hiding this comment.
Left some comments inline per the styleguide at https://github.com/dotnet/dotnet-api-docs/wiki.
src/Mvc/Mvc.ViewFeatures/src/ViewDataDictionaryControllerPropertyActivator.cs
Outdated
Show resolved
Hide resolved
captainsafia
approved these changes
Oct 7, 2020
|
@HaoK could you retarget this to 5.0? |
|
Do you mean 6.0? master? Isn't this already targeting release/5.0? |
|
Sorry, yes |
Add missed files Apply suggestions from code review Co-authored-by: Safia Abdalla <[email protected]> PR feedback Update ViewDataEvaluator.cs Update ViewComponentConventions.cs Update TryGetValueProvider.cs Update MvcViewFeaturesMvcCoreBuilderExtensions.cs Update src/Mvc/Mvc.ViewFeatures/src/HtmlHelper.cs Co-authored-by: Safia Abdalla <[email protected]> Update src/Mvc/Mvc.ViewFeatures/src/HtmlHelper.cs Co-authored-by: Safia Abdalla <[email protected]> Update src/Mvc/Mvc.ViewFeatures/src/HtmlHelper.cs Co-authored-by: Safia Abdalla <[email protected]> Update src/Mvc/Mvc.ViewFeatures/src/HtmlHelper.cs Co-authored-by: Safia Abdalla <[email protected]> Update src/Mvc/Mvc.ViewFeatures/src/HtmlHelper.cs Co-authored-by: Safia Abdalla <[email protected]> Update src/Mvc/Mvc.ViewFeatures/src/HtmlHelper.cs Co-authored-by: Safia Abdalla <[email protected]> Trigger rebuild
HaoK
requested review from
BrennanConroy,
dougbu,
halter73,
javiercn,
jkotalik,
SteveSandersonMS and
Tratcher
as code owners
|
Rebased to master |
|
Hello @HaoK! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Oddly, AzDO doesn't seem to have any details information about the last aspnetcore-ci run other than it timed out after about 55 minutes |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26397