Adds test and lets us test against empty strings #28021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Addresses #28019
This makes it compliant with RFC6902 4.6 saying
Two empty strings should be
equal
.Might also want to remove the null check on current value completely, seeing as RFC6902 specifies that
literals (false, true, and null): are considered equal if they are the same
. Testing a null value against a null value would now fail. As I read the spec, they should be considered equal.